From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector
Date: Tue, 19 Oct 2010 23:49:29 +0200 [thread overview]
Message-ID: <20101019234929.3d4d14f4@endymion.delvare> (raw)
In-Reply-To: <1287521453.9690.299.camel@groeck-laptop>
On Tue, 19 Oct 2010 13:50:53 -0700, Guenter Roeck wrote:
> Hi Jean,
>
> On Tue, 2010-10-19 at 13:06 -0400, Jean Delvare wrote:
> [ ... ]
> > > +
> > > +/*
> > > + * I2C init/probing/exit functions
> > > + */
> > > +static int __devinit pca9541_probe(struct i2c_client *client,
> > > + const struct i2c_device_id *id)
> >
> > The use of __devinit and __devexit isn't recommended for i2c drivers.
> > If your driver is built into the kernel but the underlying i2c bus
> > driver is build as a module, you're in trouble.
> >
> I don't mind changing this, but ... the code is copied from pca954x.c,
> which also uses __devinit and __devexit for the same functions. Wouldn't
> that be a problem there as well ? Or am I missing something ?
You're right, this should be fixed. I take patches ;)
--
Jean Delvare
next prev parent reply other threads:[~2010-10-19 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 1:15 [PATCH v2] i2c/mux: Driver for PCA9541 I2C Master Selector Guenter Roeck
[not found] ` <1286932516-20689-1-git-send-email-guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-10-16 1:58 ` Guenter Roeck
2010-10-19 17:06 ` Jean Delvare
[not found] ` <20101019190647.314302e7-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-19 18:08 ` Guenter Roeck
[not found] ` <20101019180805.GA31594-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2010-10-19 18:31 ` Jean Delvare
2010-10-19 20:50 ` Guenter Roeck
2010-10-19 21:49 ` Jean Delvare [this message]
[not found] ` <20101019234929.3d4d14f4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-10-19 21:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019234929.3d4d14f4@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=giometti-k2GhghHVRtY@public.gmane.org \
--cc=guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox