From: Paul Mundt <lethal-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
To: Nobuhiro Iwamatsu <iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org>
Cc: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*
Date: Tue, 26 Oct 2010 13:02:03 +0900 [thread overview]
Message-ID: <20101026040203.GB16265@linux-sh.org> (raw)
In-Reply-To: <AANLkTikh+h1nWHZCa29FQc1dw=z3ZhYEW8eSyFyS4C84-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Oct 26, 2010 at 09:08:12AM +0900, Nobuhiro Iwamatsu wrote:
> 2010/10/25 Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>:
> > On Mon, Oct 25, 2010 at 08:13:25PM +0900, Paul Mundt wrote:
> >> On Mon, Oct 25, 2010 at 11:47:18AM +0100, Ben Dooks wrote:
> >> > On Mon, Oct 25, 2010 at 10:58:35AM +0900, Paul Mundt wrote:
> >> > > On Sat, Oct 23, 2010 at 07:07:00AM +0900, Nobuhiro Iwamatsu wrote:
> >> > > > ctrl_* is deprecated. We should to use __raw_*.
> >> > > >
> >> > > > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org>
> >> > >
> >> > > Applied, thanks.
> >> >
> >> > Hi, can you see my comments about the copy of this posted below
> >> > about ioremap() and use or __raw accessors?
> >> >
> >> No? At least it never made it to the list. Do you have a pointer handy?
> >
> > http://marc.info/?l=linux-i2c&m=128797023230600&w=2
> >
>
> Sorry, this is my mistake.
>
> >> On Sun, Oct 24, 2010 at 05:37:46PM +0900, Nobuhiro Iwamatsu wrote:
> >> ctrl_* is deprecated. We should to use __raw_*.
> >
> >> Given iobase is ioremap() returned, there should be an explicit reason
> >> for using __raw_xxx() instead of read/writel().
>
Based on what, exactly? The CPU in question is quite content with the
weak ordering provided by __raw_xxx(), anything more is unecessary.
next prev parent reply other threads:[~2010-10-26 4:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 22:07 [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_* Nobuhiro Iwamatsu
2010-10-25 1:58 ` Paul Mundt
[not found] ` <20101025015835.GE2173-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2010-10-25 10:47 ` Ben Dooks
[not found] ` <20101025104718.GF21564-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-10-25 11:13 ` Paul Mundt
[not found] ` <20101025111324.GA16265-M7jkjyW5wf5g9hUCZPvPmw@public.gmane.org>
2010-10-25 12:42 ` Ben Dooks
2010-10-26 0:08 ` Nobuhiro Iwamatsu
[not found] ` <AANLkTikh+h1nWHZCa29FQc1dw=z3ZhYEW8eSyFyS4C84-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-26 4:02 ` Paul Mundt [this message]
2010-10-26 6:43 ` Ben Dooks
2010-10-26 6:50 ` Paul Mundt
-- strict thread matches above, loose matches on Subject: below --
2010-10-24 8:37 Nobuhiro Iwamatsu
[not found] ` <1287909466-16898-1-git-send-email-iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org>
2010-10-25 1:30 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026040203.GB16265@linux-sh.org \
--to=lethal-m7jkjyw5wf5g9huczpvpmw@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).