From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 1/2 v2] i2c-i801: Handle multiple instances instead of keeping global state Date: Sun, 31 Oct 2010 20:39:36 +0100 Message-ID: <20101031203936.2025b2c4@endymion.delvare> References: <1288538382.4570.48.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1288538382.4570.48.camel-uXGAPMMVk8bAQYKIod7YupZV94DADvEd@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Woodhouse Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Sun, 31 Oct 2010 11:19:42 -0400, David Woodhouse wrote: > It's poor form to keep driver state in global variables rather than > per-instance. It never really mattered in practice when there was onl= y > one controller on the chipset =E2=80=94 but the latest chipsets do ha= ve more > than one controller, so now we care. >=20 > Signed-off-by: David Woodhouse Applied (after fixing 6 checkpatch.pl warnings), thanks. --=20 Jean Delvare