Re: [PATCH 1/3] i2c: Delete unused adapter IDs

Jarod Wilson
2010-11-07T18:56:29Z

On Nov 5, 2010, at 4:06 PM, Jean Delvare wrote:

> Delete unused I2C adapter IDs. Special cases are:
>
> * I2C_HW_B_RIVA was still set in driver rivafb, however no other
> driver is ever looking for this value, so we can safely remove it.
> * I2C_HW_B_HDPVR is used in staging driver lirc_zilog, however no
> adapter ID is ever set to this value, so the code in question never
> runs. As the code additionally expects that I2C_HW_B_HDPVR may not
> be defined, we can delete it now and let the lirc_zilog driver
> maintainer rewrite this piece of code.
>
> Big thanks for Hans Verkuil for doing all the hard work :)
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
> Cc: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

I think I2C_HW_B_HDPVR was only being used by a not-yet-merged-upstream patch to the hdpvr driver, which enabled the IR functionality on it. Its not merged, as enabling it seems to like to lock the unit up from time to time, and nobody (myself included) has had time to figure out why. In any case, it should be perfectly fine to nuke that, we need to fix lirc_zilog regardless.

Acked-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

--
Jarod Wilson
jarod-ajLrJawYSntWk0Htik3J/w@public.gmane.org