From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: [PATCH 2/3] i2c: Drivers shouldn't include Date: Fri, 5 Nov 2010 21:07:53 +0100 Message-ID: <20101105210753.4d1a03bc@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linux I2C , LMML Cc: Michael Hunold , Mauro Carvalho Chehab List-Id: linux-i2c@vger.kernel.org Drivers don't need to include , especially not when they don't use anything that header file provides. Signed-off-by: Jean Delvare Cc: Michael Hunold Cc: Mauro Carvalho Chehab --- drivers/media/common/saa7146_i2c.c | 1 - drivers/media/video/ir-kbd-i2c.c | 1 - drivers/staging/olpc_dcon/olpc_dcon.c | 1 - 3 files changed, 3 deletions(-) --- linux-2.6.37-rc1.orig/drivers/media/common/saa7146_i2c.c 2010-11-02 09:19:35.000000000 +0100 +++ linux-2.6.37-rc1/drivers/media/common/saa7146_i2c.c 2010-11-05 15:34:25.000000000 +0100 @@ -391,7 +391,6 @@ static int saa7146_i2c_xfer(struct i2c_a /*****************************************************************************/ /* i2c-adapter helper functions */ -#include /* exported algorithm data */ static struct i2c_algorithm saa7146_algo = { --- linux-2.6.37-rc1.orig/drivers/media/video/ir-kbd-i2c.c 2010-11-02 09:19:35.000000000 +0100 +++ linux-2.6.37-rc1/drivers/media/video/ir-kbd-i2c.c 2010-11-05 15:34:18.000000000 +0100 @@ -44,7 +44,6 @@ #include #include #include -#include #include #include --- linux-2.6.37-rc1.orig/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-02 09:19:37.000000000 +0100 +++ linux-2.6.37-rc1/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-05 15:34:14.000000000 +0100 @@ -17,7 +17,6 @@ #include #include #include -#include #include #include #include -- Jean Delvare