* [PATCH 2/3] i2c: Drivers shouldn't include <linux/i2c-id.h>
@ 2010-11-05 20:07 Jean Delvare
[not found] ` <20101105210753.4d1a03bc-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2010-11-05 20:07 UTC (permalink / raw)
To: Linux I2C, LMML; +Cc: Michael Hunold, Mauro Carvalho Chehab
Drivers don't need to include <linux/i2c-id.h>, especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Michael Hunold <michael-nMDb6ONjQAQ@public.gmane.org>
Cc: Mauro Carvalho Chehab <mchehab-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
---
drivers/media/common/saa7146_i2c.c | 1 -
drivers/media/video/ir-kbd-i2c.c | 1 -
drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
3 files changed, 3 deletions(-)
--- linux-2.6.37-rc1.orig/drivers/media/common/saa7146_i2c.c 2010-11-02 09:19:35.000000000 +0100
+++ linux-2.6.37-rc1/drivers/media/common/saa7146_i2c.c 2010-11-05 15:34:25.000000000 +0100
@@ -391,7 +391,6 @@ static int saa7146_i2c_xfer(struct i2c_a
/*****************************************************************************/
/* i2c-adapter helper functions */
-#include <linux/i2c-id.h>
/* exported algorithm data */
static struct i2c_algorithm saa7146_algo = {
--- linux-2.6.37-rc1.orig/drivers/media/video/ir-kbd-i2c.c 2010-11-02 09:19:35.000000000 +0100
+++ linux-2.6.37-rc1/drivers/media/video/ir-kbd-i2c.c 2010-11-05 15:34:18.000000000 +0100
@@ -44,7 +44,6 @@
#include <linux/errno.h>
#include <linux/slab.h>
#include <linux/i2c.h>
-#include <linux/i2c-id.h>
#include <linux/workqueue.h>
#include <media/ir-core.h>
--- linux-2.6.37-rc1.orig/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-02 09:19:37.000000000 +0100
+++ linux-2.6.37-rc1/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-05 15:34:14.000000000 +0100
@@ -17,7 +17,6 @@
#include <linux/console.h>
#include <linux/i2c.h>
#include <linux/platform_device.h>
-#include <linux/i2c-id.h>
#include <linux/pci.h>
#include <linux/pci_ids.h>
#include <linux/interrupt.h>
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] i2c: Drivers shouldn't include <linux/i2c-id.h>
[not found] ` <20101105210753.4d1a03bc-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
@ 2010-11-13 14:34 ` Mauro Carvalho Chehab
2010-11-13 16:59 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2010-11-13 14:34 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, LMML, Michael Hunold
Em 05-11-2010 18:07, Jean Delvare escreveu:
> Drivers don't need to include <linux/i2c-id.h>, especially not when
> they don't use anything that header file provides.
>
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Michael Hunold <michael-nMDb6ONjQAQ@public.gmane.org>
> Cc: Mauro Carvalho Chehab <mchehab-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
I suspect that you want to include it via your tree, so:
Acked-by: Mauro Carvalho Chehab <mchehab-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/media/common/saa7146_i2c.c | 1 -
> drivers/media/video/ir-kbd-i2c.c | 1 -
> drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- linux-2.6.37-rc1.orig/drivers/media/common/saa7146_i2c.c 2010-11-02 09:19:35.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/media/common/saa7146_i2c.c 2010-11-05 15:34:25.000000000 +0100
> @@ -391,7 +391,6 @@ static int saa7146_i2c_xfer(struct i2c_a
>
> /*****************************************************************************/
> /* i2c-adapter helper functions */
> -#include <linux/i2c-id.h>
>
> /* exported algorithm data */
> static struct i2c_algorithm saa7146_algo = {
> --- linux-2.6.37-rc1.orig/drivers/media/video/ir-kbd-i2c.c 2010-11-02 09:19:35.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/media/video/ir-kbd-i2c.c 2010-11-05 15:34:18.000000000 +0100
> @@ -44,7 +44,6 @@
> #include <linux/errno.h>
> #include <linux/slab.h>
> #include <linux/i2c.h>
> -#include <linux/i2c-id.h>
> #include <linux/workqueue.h>
>
> #include <media/ir-core.h>
> --- linux-2.6.37-rc1.orig/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-02 09:19:37.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-05 15:34:14.000000000 +0100
> @@ -17,7 +17,6 @@
> #include <linux/console.h>
> #include <linux/i2c.h>
> #include <linux/platform_device.h>
> -#include <linux/i2c-id.h>
> #include <linux/pci.h>
> #include <linux/pci_ids.h>
> #include <linux/interrupt.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/3] i2c: Drivers shouldn't include <linux/i2c-id.h>
2010-11-13 14:34 ` Mauro Carvalho Chehab
@ 2010-11-13 16:59 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2010-11-13 16:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux I2C, LMML, Michael Hunold
On Sat, 13 Nov 2010 12:34:23 -0200, Mauro Carvalho Chehab wrote:
> Em 05-11-2010 18:07, Jean Delvare escreveu:
> > Drivers don't need to include <linux/i2c-id.h>, especially not when
> > they don't use anything that header file provides.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Michael Hunold <michael@mihu.de>
> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>
> I suspect that you want to include it via your tree, so:
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Indeed, thanks.
> > ---
> > drivers/media/common/saa7146_i2c.c | 1 -
> > drivers/media/video/ir-kbd-i2c.c | 1 -
> > drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > --- linux-2.6.37-rc1.orig/drivers/media/common/saa7146_i2c.c 2010-11-02 09:19:35.000000000 +0100
> > +++ linux-2.6.37-rc1/drivers/media/common/saa7146_i2c.c 2010-11-05 15:34:25.000000000 +0100
> > @@ -391,7 +391,6 @@ static int saa7146_i2c_xfer(struct i2c_a
> >
> > /*****************************************************************************/
> > /* i2c-adapter helper functions */
> > -#include <linux/i2c-id.h>
> >
> > /* exported algorithm data */
> > static struct i2c_algorithm saa7146_algo = {
> > --- linux-2.6.37-rc1.orig/drivers/media/video/ir-kbd-i2c.c 2010-11-02 09:19:35.000000000 +0100
> > +++ linux-2.6.37-rc1/drivers/media/video/ir-kbd-i2c.c 2010-11-05 15:34:18.000000000 +0100
> > @@ -44,7 +44,6 @@
> > #include <linux/errno.h>
> > #include <linux/slab.h>
> > #include <linux/i2c.h>
> > -#include <linux/i2c-id.h>
> > #include <linux/workqueue.h>
> >
> > #include <media/ir-core.h>
> > --- linux-2.6.37-rc1.orig/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-02 09:19:37.000000000 +0100
> > +++ linux-2.6.37-rc1/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-05 15:34:14.000000000 +0100
> > @@ -17,7 +17,6 @@
> > #include <linux/console.h>
> > #include <linux/i2c.h>
> > #include <linux/platform_device.h>
> > -#include <linux/i2c-id.h>
> > #include <linux/pci.h>
> > #include <linux/pci_ids.h>
> > #include <linux/interrupt.h>
> >
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-13 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-05 20:07 [PATCH 2/3] i2c: Drivers shouldn't include <linux/i2c-id.h> Jean Delvare
[not found] ` <20101105210753.4d1a03bc-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-11-13 14:34 ` Mauro Carvalho Chehab
2010-11-13 16:59 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).