From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Tomoya MORINAGA
<tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
srinidhi kasagar
<srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] EG20T: Update PCH_I2C driver to 2.6.36
Date: Mon, 6 Dec 2010 08:53:04 +0100 [thread overview]
Message-ID: <20101206085304.094d1078@endymion.delvare> (raw)
In-Reply-To: <4CFC6622.1050006-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
On Mon, 06 Dec 2010 04:27:14 +0000, Ben Dooks wrote:
> On 09/11/10 04:25, Tomoya MORINAGA wrote:
> > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile
> > index c3ef492..e55e051 100644
> > --- a/drivers/i2c/busses/Makefile
> > +++ b/drivers/i2c/busses/Makefile
> > @@ -60,6 +60,7 @@ obj-$(CONFIG_I2C_STU300) += i2c-stu300.o
> > obj-$(CONFIG_I2C_VERSATILE) += i2c-versatile.o
> > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o
> > obj-$(CONFIG_I2C_XILINX) += i2c-xiic.o
> > +obj-$(CONFIG_I2C_EG20T) += i2c-eg20t.o
>
> Jean, do you want these alphabetically sorted?
I prefer them sorted alphabetically, yes. For several reasons:
* Makes it easier to find out a specific entry.
* Makes it easier to spot duplicate drivers or drivers for very similar
devices which could be merged.
* Limits the risks of reject when two new drivers are added in parallel.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2010-12-06 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 4:25 [PATCH] EG20T: Update PCH_I2C driver to 2.6.36 Tomoya MORINAGA
2010-12-06 4:27 ` Ben Dooks
[not found] ` <4CFC6622.1050006-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-12-06 7:53 ` Jean Delvare [this message]
2010-12-07 1:38 ` Tomoya MORINAGA
[not found] ` <4CD8CD32.5000909-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-11-09 5:21 ` Wang, Qi
[not found] ` <D5AB6E638E5A3E4B8F4406B113A5A19A3012F51E-QQHDSDV1ERZpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2010-11-09 8:29 ` Jean Delvare
[not found] ` <20101109092944.0670d428-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-11-09 9:50 ` Ben Dooks
[not found] ` <20101109095012.GA21564-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-11-30 1:39 ` Wang, Qi
2010-12-06 4:41 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206085304.094d1078@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=tomoya-linux-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox