From: Jean Delvare <khali@linux-fr.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-i2c@vger.kernel.org, linux-alpha@vger.kernel.org
Subject: Re: [PATCH] i2c-i801: Include <linux/slab.h>
Date: Sun, 12 Dec 2010 09:25:59 +0100 [thread overview]
Message-ID: <20101212092559.10f6883e@endymion.delvare> (raw)
In-Reply-To: <1292100331.3136.47.camel@localhost>
Hi Ben,
On Sat, 11 Dec 2010 20:45:31 +0000, Ben Hutchings wrote:
> Commit 5a0e3ad6af8660be21ca98a971cd00f331318c05 added direct inclusion
> of <linux/slab.h> to those source files that appeared to need it, but
> somehow missed this.
Most probably because the i2c-i801 driver didn't do any memory
allocation until this recent change:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0cd96eb0a74791cacb27ace902b991cfd0e72abe
> On most architectures <linux/slab.h> is still
> indirectly included, but there are exceptions such as alpha.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/i2c/busses/i2c-i801.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 02835ce..7979aef 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -72,6 +72,7 @@
> #include <linux/acpi.h>
> #include <linux/io.h>
> #include <linux/dmi.h>
> +#include <linux/slab.h>
>
> /* I801 SMBus address offsets */
> #define SMBHSTSTS(p) (0 + (p)->smba)
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2010-12-12 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 20:45 [PATCH] i2c-i801: Include <linux/slab.h> Ben Hutchings
2010-12-12 8:25 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101212092559.10f6883e@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben@decadent.org.uk \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).