* [PATCH] i2c-i801: Include <linux/slab.h>
@ 2010-12-11 20:45 Ben Hutchings
2010-12-12 8:25 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2010-12-11 20:45 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c, linux-alpha
Commit 5a0e3ad6af8660be21ca98a971cd00f331318c05 added direct inclusion
of <linux/slab.h> to those source files that appeared to need it, but
somehow missed this. On most architectures <linux/slab.h> is still
indirectly included, but there are exceptions such as alpha.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/i2c/busses/i2c-i801.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 02835ce..7979aef 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -72,6 +72,7 @@
#include <linux/acpi.h>
#include <linux/io.h>
#include <linux/dmi.h>
+#include <linux/slab.h>
/* I801 SMBus address offsets */
#define SMBHSTSTS(p) (0 + (p)->smba)
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c-i801: Include <linux/slab.h>
2010-12-11 20:45 [PATCH] i2c-i801: Include <linux/slab.h> Ben Hutchings
@ 2010-12-12 8:25 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2010-12-12 8:25 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-i2c, linux-alpha
Hi Ben,
On Sat, 11 Dec 2010 20:45:31 +0000, Ben Hutchings wrote:
> Commit 5a0e3ad6af8660be21ca98a971cd00f331318c05 added direct inclusion
> of <linux/slab.h> to those source files that appeared to need it, but
> somehow missed this.
Most probably because the i2c-i801 driver didn't do any memory
allocation until this recent change:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0cd96eb0a74791cacb27ace902b991cfd0e72abe
> On most architectures <linux/slab.h> is still
> indirectly included, but there are exceptions such as alpha.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/i2c/busses/i2c-i801.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 02835ce..7979aef 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -72,6 +72,7 @@
> #include <linux/acpi.h>
> #include <linux/io.h>
> #include <linux/dmi.h>
> +#include <linux/slab.h>
>
> /* I801 SMBus address offsets */
> #define SMBHSTSTS(p) (0 + (p)->smba)
Applied, thanks.
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-12 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-11 20:45 [PATCH] i2c-i801: Include <linux/slab.h> Ben Hutchings
2010-12-12 8:25 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).