linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Rabin Vincent <rabin-66gdRtMMWGc@public.gmane.org>,
	rjw-KKrjLPT3xs0@public.gmane.org,
	linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [linux-pm] pm_runtime_suspended() and non-pm_runtime-using (i2c) drivers
Date: Tue, 14 Dec 2010 22:00:51 +0000	[thread overview]
Message-ID: <20101214220050.GB25106@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1012141406500.2087-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>

On Tue, Dec 14, 2010 at 02:10:58PM -0500, Alan Stern wrote:

> I see.  It sounds like you're really saying that new devices default to 
> the wrong runtime state.  If pm_runtime_init() would set new devices to 
> RPM_ACTIVE instead of RPM_SUSPENDED then this problem wouldn't arise.  
> Children could do whatever they want, and even if the parent's driver 
> was totally ignorant of runtime PM, it would work out.

In this case that's the desired behaviour but I worry that it'd break
some other use case (eg, keeping a parent awake because there was an
unclaimed device sitting around).  

When I've been working with the runtime PM subsystem before I've thought
that it might be nice to have a specific RPM_UNINITIAZLIZED state which
would generally get out of the way.  It might be a bit clearer than the
current situation conceptually but I've never felt I had a firm enough
grasp on what was going on to really say, everything always feels more
complicated than I feel it should if I understood it properly.

Thinking about it in the case of I2C we probably also want to mark the
device as ignoring its children when it registers as an I2C controller,
while an I2C controller that does runtime PM will probably figure this
out for itself it would save a bit of effort.

  parent reply	other threads:[~2010-12-14 22:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-14 15:54 pm_runtime_suspended() and non-pm_runtime-using (i2c) drivers Rabin Vincent
     [not found] ` <AANLkTik7D2mDJN=BaasvLa4xx0fQBgjHREqQB06aD9JU-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-14 16:16   ` [linux-pm] " Alan Stern
     [not found]     ` <Pine.LNX.4.44L0.1012141114150.2087-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-12-14 16:40       ` Mark Brown
     [not found]         ` <20101214164059.GE5723-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2010-12-14 17:44           ` Alan Stern
     [not found]             ` <Pine.LNX.4.44L0.1012141236530.2087-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-12-14 18:09               ` Mark Brown
     [not found]                 ` <20101214180941.GB13644-HF5t3jzXg/6ND3a5+9QAFujbO/Zr0HzV@public.gmane.org>
2010-12-14 19:10                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1012141406500.2087-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-12-14 22:00                       ` Mark Brown [this message]
     [not found]                         ` <20101214220050.GB25106-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2010-12-14 23:03                           ` Alan Stern
     [not found]                             ` <Pine.LNX.4.44L0.1012141754190.2087-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-12-14 23:19                               ` Mark Brown
2010-12-15  0:15                       ` Rafael J. Wysocki
2010-12-14 23:28       ` Rafael J. Wysocki
     [not found]         ` <201012150028.07938.rjw-KKrjLPT3xs0@public.gmane.org>
2010-12-14 23:57           ` Rafael J. Wysocki
     [not found]             ` <201012150057.31237.rjw-KKrjLPT3xs0@public.gmane.org>
2010-12-15  0:19               ` Rafael J. Wysocki
     [not found]                 ` <201012150119.59801.rjw-KKrjLPT3xs0@public.gmane.org>
2010-12-15 20:38                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1012151530590.2171-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2010-12-15 22:01                       ` Rafael J. Wysocki
     [not found]                         ` <201012152301.18700.rjw-KKrjLPT3xs0@public.gmane.org>
2010-12-15 23:39                           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101214220050.GB25106@opensource.wolfsonmicro.com \
    --to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=rabin-66gdRtMMWGc@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).