[PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings

[PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
dependency tree hierarchy is satisfied.  This eliminates the
kconfig warning:

warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)

Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 drivers/gpio/Kconfig       |    1 +
 drivers/i2c/busses/Kconfig |    1 +
 2 files changed, 2 insertions(+)

--- lnx-2637-rc4.orig/drivers/gpio/Kconfig
+++ lnx-2637-rc4/drivers/gpio/Kconfig
@@ -102,6 +102,7 @@ config GPIO_VR41XX
 config GPIO_SCH
 	tristate "Intel SCH GPIO"
 	depends on GPIOLIB && PCI
+	select MFD_SUPPORT
 	select MFD_CORE
 	select LPC_SCH
 	help
--- lnx-2637-rc4.orig/drivers/i2c/busses/Kconfig
+++ lnx-2637-rc4/drivers/i2c/busses/Kconfig
@@ -107,6 +107,7 @@ config I2C_I801
 config I2C_ISCH
 	tristate "Intel SCH SMBus 1.0"
 	depends on PCI
+	select MFD_SUPPORT
 	select MFD_CORE
 	select LPC_SCH
 	help

Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings

[Jean Delvare]

Hi Randy,

On Tue, 14 Dec 2010 16:26:56 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> 
> I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
> dependency tree hierarchy is satisfied.  This eliminates the
> kconfig warning:
> 
> warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
>  drivers/gpio/Kconfig       |    1 +
>  drivers/i2c/busses/Kconfig |    1 +
>  2 files changed, 2 insertions(+)
> 
> --- lnx-2637-rc4.orig/drivers/gpio/Kconfig
> +++ lnx-2637-rc4/drivers/gpio/Kconfig
> @@ -102,6 +102,7 @@ config GPIO_VR41XX
>  config GPIO_SCH
>  	tristate "Intel SCH GPIO"
>  	depends on GPIOLIB && PCI
> +	select MFD_SUPPORT
>  	select MFD_CORE
>  	select LPC_SCH
>  	help
> --- lnx-2637-rc4.orig/drivers/i2c/busses/Kconfig
> +++ lnx-2637-rc4/drivers/i2c/busses/Kconfig
> @@ -107,6 +107,7 @@ config I2C_I801
>  config I2C_ISCH
>  	tristate "Intel SCH SMBus 1.0"
>  	depends on PCI
> +	select MFD_SUPPORT
>  	select MFD_CORE
>  	select LPC_SCH
>  	help

It seems wrong to have to select both MFD_SUPPORT and MFD_CORE. Can't
the MFD subsystem be cleaned up so that subdrivers have a single symbol
to select beyond their own?

I don't quite get the point of MFD_CORE. MFD_SUPPORT could be made
tristate, and MFD_CORE dropped (and then MFD_SUPPORT renamed to
MFD_CORE to minimize the changes.) This is exactly how I2C support is
implemented, for example.

-- 
Jean Delvare

Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings

[Randy Dunlap]

On 12/15/10 01:15, Jean Delvare wrote:
> Hi Randy,
> 
> On Tue, 14 Dec 2010 16:26:56 -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>>
>> I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
>> dependency tree hierarchy is satisfied.  This eliminates the
>> kconfig warning:
>>
>> warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>> Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>>  drivers/gpio/Kconfig       |    1 +
>>  drivers/i2c/busses/Kconfig |    1 +
>>  2 files changed, 2 insertions(+)
>>
>> --- lnx-2637-rc4.orig/drivers/gpio/Kconfig
>> +++ lnx-2637-rc4/drivers/gpio/Kconfig
>> @@ -102,6 +102,7 @@ config GPIO_VR41XX
>>  config GPIO_SCH
>>  	tristate "Intel SCH GPIO"
>>  	depends on GPIOLIB && PCI
>> +	select MFD_SUPPORT
>>  	select MFD_CORE
>>  	select LPC_SCH
>>  	help
>> --- lnx-2637-rc4.orig/drivers/i2c/busses/Kconfig
>> +++ lnx-2637-rc4/drivers/i2c/busses/Kconfig
>> @@ -107,6 +107,7 @@ config I2C_I801
>>  config I2C_ISCH
>>  	tristate "Intel SCH SMBus 1.0"
>>  	depends on PCI
>> +	select MFD_SUPPORT
>>  	select MFD_CORE
>>  	select LPC_SCH
>>  	help
> 
> It seems wrong to have to select both MFD_SUPPORT and MFD_CORE. Can't
> the MFD subsystem be cleaned up so that subdrivers have a single symbol
> to select beyond their own?
> 
> I don't quite get the point of MFD_CORE. MFD_SUPPORT could be made
> tristate, and MFD_CORE dropped (and then MFD_SUPPORT renamed to
> MFD_CORE to minimize the changes.) This is exactly how I2C support is
> implemented, for example.

OK, I'll look into that.  Thanks.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] GPIO_SCH and I2C_SCH: select MFD_SUPPORT to eliminate kconfig warnings

[Ben Dooks]

On Wed, Dec 15, 2010 at 12:11:09PM -0800, Randy Dunlap wrote:
> On 12/15/10 01:15, Jean Delvare wrote:
> > Hi Randy,
> > 
> > On Tue, 14 Dec 2010 16:26:56 -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >>
> >> I2C_ISCH and GPIO_SCH need to select MFD_SUPPORT so that the
> >> dependency tree hierarchy is satisfied.  This eliminates the
> >> kconfig warning:
> >>
> >> warning: (I2C_ISCH && I2C && PCI || GPIO_SCH && GPIOLIB && PCI) selects LPC_SCH which has unmet direct dependencies (MFD_SUPPORT && PCI)
> >>

Hmm, it seems that MFD_SUPPORT enables MFD_CORE, and as such, I don't
think MFD_CORE can be selected without the MFD_SUPPORT.

My view would be to add MFD_NEEDED, or NEEDS_MFD which would force
the MFD_SUPPORT and MFD_CORE on in one go.

-- 
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.