public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Matthias Zacharias
	<Matthias.Zacharias-zGrmWZs6xXT+aS/vkh9bjw@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Need help to fix some issues with the linux driver   "i2c-gpio"
Date: Thu, 16 Dec 2010 13:52:02 +0100	[thread overview]
Message-ID: <20101216135202.38ce671a@endymion.delvare> (raw)
In-Reply-To: <4D09F8B7020000AA00008369-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>

On Thu, 16 Dec 2010 11:32:07 +0100, Matthias Zacharias wrote:
> With the new patch the driver is working fine, also with i2c_debug =
> 3.
> 
> See the screenshot in my dropbox
> (http://www.dropbox.com/gallery/16457261/1/I2C_2_MLX90614?h=8e2a46)

Looks good, great. I'll send the patch for review and comments to both
the linux-i2c list and LKML later today.

Do you want me to list you as a tester in the patch header? If I do
that, I'll have to include your name and e-mail address, so I need to
know if this is OK with you.

> > (...)
> > Just publish it as is, and I'll review it publicly. It will
> > certainly take a number of round trips to get it right, if this is
> > your first contribution, but that's OK.
> >
> 
> This MLX90614 driver has a reduced functionality. It was tailored for
> our application which use only the temperature read function.
> Also the SMBus address is fix defined in the source code, and no
> checkes if the factory preprogramming is correct are done.
> The option to manage the configuration of the MLX90614 as described in
> the datasheets is not yet implemented, because we don't need it.

This is totally OK. Others can add functionalities to the driver later
if needed.

> > (...)
> > FYI, I have asked Melexis for an MLX90614 evaluation board, they
> > have sent something to me, so as soon as I receive it I should be
> > able to test your driver.
> 
> The evalutionboard (EVB) shiped by Melexis uses his own microcontroller
> on that board and communicate to the PC via USB. In our system the
> MLX90614 sensor is connected directly to the port pins of the
> microcontroller.

I know that. I don't plan to actually use the micro-controller on the
evaluation board. There are I2C pins on the board, and I'll connect an
external I2C master [1] to them.

[1] http://www.harbaum.org/till/i2c_tiny_usb/index.shtml

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

  parent reply	other threads:[~2010-12-16 12:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 10:26 Need help to fix some issues with the linux driver "i2c-gpio" Matthias Zacharias
     [not found] ` <4CF4DF5E020000AA0000808F-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-11-30 16:44   ` Bill Gatliff
     [not found]     ` <AANLkTik9rHn0QE3MzD-yViMPw2hm0VpFRjch-hf6n_xZ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-01  8:55       ` Antw: " Matthias Zacharias
2010-11-30 17:21   ` Jean Delvare
     [not found]     ` <20101130182150.3bbc8f01-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-01 10:01       ` Antw: " Matthias Zacharias
     [not found]         ` <4CF62AFD020000AA000080E3-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-12-02 16:23           ` Jean Delvare
     [not found]             ` <20101202172322.43ea4698-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-06  8:44               ` Antw: " Matthias Zacharias
     [not found]                 ` <4CFCB095020000AA00008187-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-12-06 10:25                   ` Jean Delvare
     [not found]                     ` <20101206112557.3dc8ffe3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-10 15:21                       ` Antw: " Matthias Zacharias
     [not found]                         ` <20101211172336.35c434ef@endymion.delvare>
     [not found]                           ` <20101211172336.35c434ef-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-14 14:14                             ` Matthias Zacharias
     [not found]                               ` <4D0789C5020000AA00008346-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-12-14 16:58                                 ` Jean Delvare
     [not found]                                   ` <20101214175828.0a62ce3f-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-15 12:46                                     ` Antw: " Matthias Zacharias
     [not found]                                       ` <4D08C6B2020000AA0000835E-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-12-15 14:42                                         ` Jean Delvare
     [not found]                                           ` <20101215154255.20d471a4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-16 10:32                                             ` Antw: " Matthias Zacharias
     [not found]                                               ` <4D09F8B7020000AA00008369-PZWwcLLCDcw8dQ1qNLwSjGRXbTvXh2ZWs0AfqQuZ5sE@public.gmane.org>
2010-12-16 12:52                                                 ` Jean Delvare [this message]
     [not found]                                                   ` <20101216135202.38ce671a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-12-16 13:27                                                     ` Matthias Zacharias
  -- strict thread matches above, loose matches on Subject: below --
2010-11-22 10:11 Matthias Zacharias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216135202.38ce671a@endymion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=Matthias.Zacharias-zGrmWZs6xXT+aS/vkh9bjw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox