From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] i2c: Factor out runtime suspend checks from PM operations Date: Wed, 22 Dec 2010 20:14:14 +0000 Message-ID: <20101222201413.GB8167@opensource.wolfsonmicro.com> References: <1293041268-7707-1-git-send-email-broonie@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rabin Vincent Cc: rjw-KKrjLPT3xs0@public.gmane.org, Ben Dooks , Jean Delvare , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thu, Dec 23, 2010 at 12:49:39AM +0530, Rabin Vincent wrote: > And even if we did want to support runtime PM interaction for legacy > ops, the code for restore() above suffers from the problem of setting > active even when no callback exists, like I mentioned in the same email > for resume(): I agree it's confused, I posted an updated patch which should behave exactly as the old code did - I think the confusion with the legacy behaviour should be addressed seperately (and ideally in 2.6.37 or at least a stable patch rather than 2.6.38 which is where the current patch is targetted).