From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Dmitry Eremin-Solenikov
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit
Date: Wed, 5 Jan 2011 09:24:45 +0100 [thread overview]
Message-ID: <20110105082445.GL25121@pengutronix.de> (raw)
In-Reply-To: <1294193110-23958-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
a bit of explanation would be nice here. Something like:
Subject: i2c-pxa: make sure the remove callback is called on unbind
When a "pxa2xx-i2c" device was unbound (e.g. via sysfs) the remove
callback was not called because it was discarded after boot or module
load time. Because of that the resources allocated in probe were not
freed and so a rebind was impossible.
Fix that by moving the remove callback to .devexit.text.
This way everyone can understand that a real bug is fixed here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-01-05 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 2:05 [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Dmitry Eremin-Solenikov
[not found] ` <1294193110-23958-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-05 8:24 ` Uwe Kleine-König [this message]
[not found] ` <20110105082445.GL25121-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-05 9:19 ` Ben Dooks
[not found] ` <20110105091915.GV27131-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-01-06 11:01 ` [PATCH] i2c-pxa: fix unbidding/rebidding of the device Dmitry Eremin-Solenikov
[not found] ` <1294311682-13287-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-06 12:40 ` Uwe Kleine-König
[not found] ` <20110106124028.GX25121-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-08 16:06 ` [PATCH] i2c-pxa: fix unbinding/rebinding " Dmitry Eremin-Solenikov
[not found] ` <1294502804-6580-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-08 16:18 ` Uwe Kleine-König
[not found] ` <20110108161828.GC8237-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-02-15 13:59 ` Dmitry Eremin-Solenikov
[not found] ` <AANLkTimO1KFNm5xZ+2qJoGQq-ndVg0ER3KKwf0RYYOLK-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-15 16:23 ` Uwe Kleine-König
2011-01-05 12:17 ` [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Ben Dooks
2011-01-08 17:42 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105082445.GL25121@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).