From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Dimitris Papastamos
<dp-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] drivers: i2c-core: Add trace events for i2c_master_send()/i2c_master_recv()
Date: Thu, 27 Jan 2011 13:33:21 +0100 [thread overview]
Message-ID: <20110127133321.589ff095@endymion.delvare> (raw)
In-Reply-To: <1296126066-15951-1-git-send-email-dp-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
On Thu, 27 Jan 2011 11:01:06 +0000, Dimitris Papastamos wrote:
> Add basic trace events for i2c_master_send() and i2c_master_recv() so we
> can observe the I2C activity without filling up the dmesg ring buffer. It
> also makes it easy to enable and disable tracing of the i2c-core.
This doesn't make sense. If you want to trace something, trace
i2c_transfer(). i2c_master_send() and i2c_master_recv() are only helpers
for the most simple cases, so tracing only them is pointless.
Note that even with this, you'll miss calls to i2c_smbus_xfer(), which
is the other access point to I2C/SMBus controllers. So I guess you want
to trace it as well.
--
Jean Delvare
next prev parent reply other threads:[~2011-01-27 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 11:01 [PATCH] drivers: i2c-core: Add trace events for i2c_master_send()/i2c_master_recv() Dimitris Papastamos
[not found] ` <1296126066-15951-1-git-send-email-dp-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-01-27 12:33 ` Jean Delvare [this message]
[not found] ` <20110127133321.589ff095-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-01-27 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127133321.589ff095@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dp-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox