From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c-stu300: make sure adapter-name is terminated Date: Mon, 31 Jan 2011 15:26:55 +0100 Message-ID: <20110131152655.5a364fbe@endymion.delvare> References: <1296482963-27368-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1296482963-27368-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , Ben Dooks List-Id: linux-i2c@vger.kernel.org On Mon, 31 Jan 2011 15:09:23 +0100, Wolfram Sang wrote: > Use strlcpy instead of strncpy. > > Signed-off-by: Wolfram Sang > Cc: Linus Walleij > Cc: Ben Dooks Acked-by: Jean Delvare Ben, please apply. > --- > > Have been bitten by this, too. Thanks to Ben for spotting it in my driver. > This was the only occurence in i2c/busses. I wish strncpy was removed from the kernel altogether. > > drivers/i2c/busses/i2c-stu300.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c > index 495be45..266135d 100644 > --- a/drivers/i2c/busses/i2c-stu300.c > +++ b/drivers/i2c/busses/i2c-stu300.c > @@ -942,7 +942,7 @@ stu300_probe(struct platform_device *pdev) > adap->owner = THIS_MODULE; > /* DDC class but actually often used for more generic I2C */ > adap->class = I2C_CLASS_DDC; > - strncpy(adap->name, "ST Microelectronics DDC I2C adapter", > + strlcpy(adap->name, "ST Microelectronics DDC I2C adapter", > sizeof(adap->name)); > adap->nr = bus_nr; > adap->algo = &stu300_algo; -- Jean Delvare