Re: [PATCH v2 4/6] i2cset: Ensure that there is no junk after the command/mode parameter

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Sun, 13 Feb 2011 12:17:24 -0800, Guenter Roeck wrote:
> Since the value mask can no longer be set after the mode command,
> we can make sure that there is no junk after the command/mode
> parameter in the command line.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
> ---
>  CHANGES        |    1 +
>  tools/i2cset.c |    3 +++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/CHANGES b/CHANGES
> index 999ff26..1ffe18f 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -5,6 +5,7 @@ SVN
>    i2c-dev.h: Make value arrays const for block write functions
>    i2cset: Add support for SMBus and I2C block writes
>            Remove obsolete means to specify value mask
> +          More stringent parameter validation
>  
>  3.0.3 (2010-12-12)
>    Makefile: Let the environment set CC and CFLAGS
> diff --git a/tools/i2cset.c b/tools/i2cset.c
> index bdc16f8..ad7da75 100644
> --- a/tools/i2cset.c
> +++ b/tools/i2cset.c
> @@ -240,6 +240,9 @@ int main(int argc, char *argv[])
>  				block[len] = value;
>  			}
>  			goto dofile;
> +		} else if (argc != flags + 6) {
> +			fprintf(stderr, "Error: Bad number of arguments!\n");
> +			help();
>  		}
>  	}

Good idea. But I think you can even be more explicit and say "Too many
arguments!".

-- 
Jean Delvare