Re: [PATCH] i2c/busses: Driver for Devantech USB-ISS I2C adapter

[Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

On Wed, Mar 23, 2011 at 09:31:57PM -0700, Guenter Roeck wrote:
> On Wed, Mar 23, 2011 at 11:31:15AM -0400, Greg KH wrote:
> > On Wed, Mar 23, 2011 at 03:10:21PM +0000, Alan Cox wrote:
> > > > But, if this just duplicates the cdc-acm interface, and it looks like it
> > > > does, I don't think you need a kernel driver at all for it.  Just use
> > > > userspace commands to the serial port, like you do on Windows, and all
> > > > should be fine, right?
> > > 
> > > You want a kernel driver because you've got kernel I²C drivers wanting to
> > > talk to the devices down the link in question. Just needs to be an ldisc
> > > and then it call comes together nicely.
> > 
> > Ah, ok, that makes more sense.
> > 
> > Odd that windows does it all from userspace, but I guess it doesn't have
> > an I2C driver subsystem.
> > 
> Converting the driver to a line discipline as Alan suggested would mean to add 
> a new line discipline to linux/tty.h.
> 
> Doing this would be purely for the benefit of the community, since the driver
> works just fine for my purpose.
> 
> So before I spend any more time on it, I'll need to know ... is there any
> interest in an i2c bus driver for this device, and would a new line discipline
> be accepted into the kernel ?

If people need/want it, a new line discipline will be accepted, no
problems with that.

thanks,

greg k-h