[PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

[PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

[Tushar Behera]

On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want
to enable support for I2C. But the I2C controller is selected only
if I2C_S3C2410 is defined.

This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 drivers/i2c/busses/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 113505a..410846c 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -549,6 +549,7 @@ config HAVE_S3C2410_I2C
 config I2C_S3C2410
 	tristate "S3C2410 I2C Driver"
 	depends on HAVE_S3C2410_I2C
+	default y
 	help
 	  Say Y here to include support for I2C controller in the
 	  Samsung SoCs.
-- 
1.7.1

Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

[Ben Dooks]

On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote:
> On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want
> to enable support for I2C. But the I2C controller is selected only
> if I2C_S3C2410 is defined.
> 
> This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected.

No. Do not do this, just having the device on the board does not mean
you want it forced into the kernel. A user may want to build it as a
module or not build it at-all.

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

[Tushar Behera]

Hi Ben,

On 24 March 2011 16:17, Ben Dooks <ben-i2c@fluff.org> wrote:
> On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote:
>> On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want
>> to enable support for I2C. But the I2C controller is selected only
>> if I2C_S3C2410 is defined.
>>
>> This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected.
>
> No. Do not do this, just having the device on the board does not mean
> you want it forced into the kernel. A user may want to build it as a
> module or not build it at-all.
>
Thanks for your comments.
> --
> Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
>
> Large Hadron Colada: A large Pina Colada that makes the universe disappear.
>
>



-- 
Tushar Behera

Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

[Ben Dooks]

On Fri, Mar 25, 2011 at 08:12:06AM +0530, Tushar Behera wrote:
> Hi Ben,
> 
> On 24 March 2011 16:17, Ben Dooks <ben-i2c@fluff.org> wrote:
> > On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote:
> >> On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want
> >> to enable support for I2C. But the I2C controller is selected only
> >> if I2C_S3C2410 is defined.
> >>
> >> This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected.
> >
> > No. Do not do this, just having the device on the board does not mean
> > you want it forced into the kernel. A user may want to build it as a
> > module or not build it at-all.
> >
> Thanks for your comments.

Sorry, default should be fine... it's select that is something that
shouldn't be done. I'll test and apply tomorrow.

That'll teach me to go reviewing stuff before the first proper coffee
of the morning.

-- 
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.