* [PATCH -next resend] i2c: designware-pcidrv depends on PCI
@ 2011-03-28 15:10 Randy Dunlap
2011-03-28 18:49 ` Baruch Siach
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2011-03-28 15:10 UTC (permalink / raw)
To: Stephen Rothwell, Baruch Siach, linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: linux-next-u79uwXL29TY76Z2rM5mHXA, LKML,
khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg
From: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
i2c-designware-pcidrv is a PCI driver and should depend on PCI.
Fixes these build errors:
drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
Signed-off-by: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20110316.orig/drivers/i2c/busses/Kconfig
+++ linux-next-20110316/drivers/i2c/busses/Kconfig
@@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM
config I2C_DESIGNWARE_PCI
tristate "Synopsys DesignWare PCI"
+ depends on PCI
help
If you say yes to this option, support will be included for the
Synopsys DesignWare I2C adapter. Only master mode is supported.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next resend] i2c: designware-pcidrv depends on PCI
2011-03-28 15:10 [PATCH -next resend] i2c: designware-pcidrv depends on PCI Randy Dunlap
@ 2011-03-28 18:49 ` Baruch Siach
0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2011-03-28 18:49 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-i2c, linux-next, LKML, khali, ben-linux
Hi Randy,
On Mon, Mar 28, 2011 at 08:10:43AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> i2c-designware-pcidrv is a PCI driver and should depend on PCI.
> Fixes these build errors:
>
> drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
> drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
>
Well, I haven't seen these PCI support patches until now, but this seems to be
OK, so, FWIW:
Acked-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig
> +++ linux-next-20110316/drivers/i2c/busses/Kconfig
> @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM
>
> config I2C_DESIGNWARE_PCI
> tristate "Synopsys DesignWare PCI"
> + depends on PCI
> help
> If you say yes to this option, support will be included for the
> Synopsys DesignWare I2C adapter. Only master mode is supported.
> --
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-28 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 15:10 [PATCH -next resend] i2c: designware-pcidrv depends on PCI Randy Dunlap
2011-03-28 18:49 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).