From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] i2c-algo-bit: Cleanup bus_test calling convention
Date: Fri, 15 Apr 2011 11:13:23 +0200 [thread overview]
Message-ID: <20110415111323.51bef2ac@endymion.delvare> (raw)
Now that we pass the i2c_adapter as the first parameter, it makes
little sense to pass its name separately as the second.
Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Alex, I think it would make sense to merge this into your own patch?
drivers/i2c/algos/i2c-algo-bit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.39-rc3.orig/drivers/i2c/algos/i2c-algo-bit.c 2011-04-15 10:47:39.000000000 +0200
+++ linux-2.6.39-rc3/drivers/i2c/algos/i2c-algo-bit.c 2011-04-15 11:05:09.000000000 +0200
@@ -232,9 +232,10 @@ static int i2c_inb(struct i2c_adapter *i
* Sanity check for the adapter hardware - check the reaction of
* the bus lines only if it seems to be idle.
*/
-static int test_bus(struct i2c_adapter *i2c_adap, char *name)
+static int test_bus(struct i2c_adapter *i2c_adap)
{
struct i2c_algo_bit_data *adap = i2c_adap->algo_data;
+ const char *name = i2c_adap->name;
int scl, sda, ret;
if (adap->pre_xfer) {
@@ -622,7 +623,7 @@ static int __i2c_bit_add_bus(struct i2c_
int ret;
if (bit_test) {
- ret = test_bus(adap, adap->name);
+ ret = test_bus(adap);
if (ret < 0)
return -ENODEV;
}
--
Jean Delvare
next reply other threads:[~2011-04-15 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 9:13 Jean Delvare [this message]
[not found] ` <20110415111323.51bef2ac-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-15 15:57 ` [PATCH] i2c-algo-bit: Cleanup bus_test calling convention Alex Deucher
[not found] ` <BANLkTikBTN-3n0AUUxM2bgMKzME8zznycg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-15 16:07 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415111323.51bef2ac@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).