From: Arnd Bergmann <arnd@arndb.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Cameron <kernel@jic23.retrosnub.co.uk>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] misc: Driver for Silicon Labs Si570 and compatibles
Date: Wed, 20 Apr 2011 18:44:30 +0200 [thread overview]
Message-ID: <201104201844.30919.arnd@arndb.de> (raw)
In-Reply-To: <1303248968-5069-1-git-send-email-guenter.roeck@ericsson.com>
On Tuesday 19 April 2011, Guenter Roeck wrote:
> This driver adds support for Si570, Si571, Si598, and Si599
> programmable XO/VCXO.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
This needs some more explanation of what the hardware is there for,
and why it's unlike everything else that we support in Linux.
We try not to have too many things in drivers/misc that are
one-off interfaces, so if the hardware is related to something
else, it should probably go into one subsystem.
My impression from readin the source code is that this is
simply a clock device that would be used in combination with
some other device in practice that consumes the clock.
If that is true, it should probably not have a user-visible
interface, but only an interface that can be used by other
kernel drivers.
Arnd
next prev parent reply other threads:[~2011-04-20 16:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 21:36 [PATCH v2] misc: Driver for Silicon Labs Si570 and compatibles Guenter Roeck
2011-04-20 9:23 ` Jonathan Cameron
[not found] ` <4DAEA618.4040801-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2011-04-20 16:34 ` Guenter Roeck
2011-04-20 16:44 ` Arnd Bergmann [this message]
2011-04-20 18:16 ` Guenter Roeck
2011-04-21 11:11 ` Arnd Bergmann
2011-04-21 15:56 ` Guenter Roeck
[not found] ` <20110421155658.GA28245-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>
2011-04-21 16:23 ` Arnd Bergmann
2011-04-21 18:47 ` Guenter Roeck
2011-04-21 19:00 ` Arnd Bergmann
2011-04-21 21:58 ` Guenter Roeck
2011-04-21 23:34 ` Hans J. Koch
2011-04-22 19:40 ` Guenter Roeck
2011-04-26 14:00 ` Arnd Bergmann
2011-04-26 15:33 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104201844.30919.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=guenter.roeck@ericsson.com \
--cc=kernel@jic23.retrosnub.co.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).