From: Jean Delvare <khali@linux-fr.org>
To: Seth Heasley <seth.heasley@intel.com>
Cc: linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 2.6.39-rc3] i2c-i801: SMBus patch for Intel Panther Point DeviceIDs
Date: Fri, 22 Apr 2011 18:44:49 +0200 [thread overview]
Message-ID: <20110422184449.06116327@endymion.delvare> (raw)
In-Reply-To: <201104201133.39979.seth.heasley@intel.com>
Hi Seth,
On Wed, 20 Apr 2011 11:33:39 -0700, Seth Heasley wrote:
> This patch adds the SMBus controller DeviceID for the Intel Panther Point PCH.
With each new chip, we have to add the SMBus device ID to pci_ids.h,
then wait for Jesse to merge that, and only then I can apply the
changes to i2c-i801.c. This approach slows things down needlessly.
It isn't mandatory to add IDs to pci_ids.h when an ID is only used
locally in a device driver. So what I would like to propose is that we
move all PCI_DEVICE_ID_INTEL_*_SMBUS declarations from pci_ids.h to
i2c-i801.c now. Then you can resubmit your Panther Point patches, and
the pci and i2c parts will be independent, so Jesse and myself don't
depend on each other to apply them.
What do you think? Jesse, any objection?
Seth, if you agree, I can take care of the move, or you can send a
patch doing that, whatever you prefer.
--
Jean Delvare
next prev parent reply other threads:[~2011-04-22 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 18:33 [PATCH 2.6.39-rc3] i2c-i801: SMBus patch for Intel Panther Point DeviceIDs Seth Heasley
2011-04-22 16:44 ` Jean Delvare [this message]
[not found] ` <20110422184449.06116327-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-22 16:47 ` Heasley, Seth
2011-04-22 16:52 ` Jesse Barnes
2011-04-22 18:20 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422184449.06116327@endymion.delvare \
--to=khali@linux-fr.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).