* Re: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c @ 2011-05-04 8:31 Marvin 0 siblings, 0 replies; 9+ messages in thread From: Marvin @ 2011-05-04 8:31 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Wei, Stephen, > Hi, Stephen > I think if doesn't need to apply the slave address codes, we can use your > patch. we use the slave address as part of our nvec mfd driver in the ac100 project, so it would be nice to have this merged. Is there any other implemenation for a driver which actually use "is_slave"? (beside the one from the older android kernels)? Regards, Marc (sorry, accidentally send by the wrong identity to the ml's) > Thanks > Wei. > > -----Original Message----- > From: Stephen Warren > Sent: Friday, April 29, 2011 11:20 PM > To: Wei Ni > Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi@profusion.mobi; > ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Olof Johansson > (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Subject: RE: [PATCH 0/2] i2c: tegra: add some new > features for tegra i2c > > Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > > Hi, all > > > > Could anyone review these changes? > > > > > > Wei, > > > > > > It looks like some of the patches I recently posted address the same > > > issues as the patches you had already posted. Sorry for the potential > > > conflicts. > > > > Hi, Stephen > > I think your patches address the different issues with my patches. > > My patches are used for retry transfer and new slave controller. > > Wei, aren't the following two patches basically the same thing, > except that yours also sets the slave address register, and is a bit > more wordy: > > http://www.spinics.net/lists/linux-i2c/msg05464.html > http://www.spinics.net/lists/linux-i2c/msg05437.html > > Upon further inspection, I don't think any of the other patches I > posted conflict with the other patch you posted. > > > > Can you please take a look at the patches I posted and comment on which > > > of those are still relevant given your patches. Even for the cases > > > where we both posted patches to address the same issue (e.g. use new > > > slave mode), there are differences in the patches. I simply took the > > > changes from the chromeos-2.6.37 kernel and cherry-picked them into > > > the mainline kernel. Are the changes you posted re-written to address > > > issues that weren't solved in the ChromeOS kernel? > > > > > > Thanks for any feedback on this. > > Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > > > *** BLURB HERE *** > > > > Wei Ni (2): > > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > > i2c: tegra: use new i2c slave controller > > > > drivers/i2c/busses/i2c-tegra.c | 57 > > +++++++++++++++++++++++++++++++++++++-- include/linux/i2c-tegra.h > > | 3 ++ > > 2 files changed, 57 insertions(+), 3 deletions(-) -- Dipl. Phys. Marc Dietrich Institut für Angewandte Physik - AG Kleinkühler - Justus-Liebig-Universität Gießen Heinrich-Buff-Ring 16 D-35392 Gießen Germany Tel. +49 641 99 33462 Fax. +49 641 99 33409 email: marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org www: http://www.uni-giessen.de/cms/iap/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/2] i2c: tegra: add some new features for tegra i2c
@ 2011-04-20 12:08 wni-DDmLM1+adcrQT0dZR+AlfA
[not found] ` <1303301312-15302-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: wni-DDmLM1+adcrQT0dZR+AlfA @ 2011-04-20 12:08 UTC (permalink / raw)
To: khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw,
ccross-z5hGa2qSFaRBDgjK7y7TUQ, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Wei Ni
From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
*** BLURB HERE ***
Wei Ni (2):
i2c: tegra: Retry transfer when unexpected/no_ack status is detected
i2c: tegra: use new i2c slave controller
drivers/i2c/busses/i2c-tegra.c | 57 +++++++++++++++++++++++++++++++++++++--
include/linux/i2c-tegra.h | 3 ++
2 files changed, 57 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <1303301312-15302-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <1303301312-15302-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> @ 2011-04-27 10:25 ` Wei Ni [not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4DB-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Wei Ni @ 2011-04-27 10:25 UTC (permalink / raw) To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org Hi, all Could anyone review these changes? Thanks Wei. -----Original Message----- From: Wei Ni Sent: Wednesday, April 20, 2011 8:09 PM To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Wei Ni Subject: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> *** BLURB HERE *** Wei Ni (2): i2c: tegra: Retry transfer when unexpected/no_ack status is detected i2c: tegra: use new i2c slave controller drivers/i2c/busses/i2c-tegra.c | 57 +++++++++++++++++++++++++++++++++++++-- include/linux/i2c-tegra.h | 3 ++ 2 files changed, 57 insertions(+), 3 deletions(-) ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4DB-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4DB-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org> @ 2011-04-27 16:29 ` Stephen Warren [not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AAC4-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Stephen Warren @ 2011-04-27 16:29 UTC (permalink / raw) To: Wei Ni Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > Hi, all > Could anyone review these changes? Wei, It looks like some of the patches I recently posted address the same issues as the patches you had already posted. Sorry for the potential conflicts. Can you please take a look at the patches I posted and comment on which of those are still relevant given your patches. Even for the cases where we both posted patches to address the same issue (e.g. use new slave mode), there are differences in the patches. I simply took the changes from the chromeos-2.6.37 kernel and cherry-picked them into the mainline kernel. Are the changes you posted re-written to address issues that weren't solved in the ChromeOS kernel? Thanks for any feedback on this. > > Thanks > Wei. > > -----Original Message----- > From: Wei Ni > Sent: Wednesday, April 20, 2011 8:09 PM > To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; > lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux- > i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Wei Ni > Subject: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c > > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > *** BLURB HERE *** > > Wei Ni (2): > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > i2c: tegra: use new i2c slave controller > > drivers/i2c/busses/i2c-tegra.c | 57 > +++++++++++++++++++++++++++++++++++++-- > include/linux/i2c-tegra.h | 3 ++ > 2 files changed, 57 insertions(+), 3 deletions(-) -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <74CDBE0F657A3D45AFBB94109FB122FF0497F1AAC4-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AAC4-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> @ 2011-04-29 6:08 ` Wei Ni [not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E2-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Wei Ni @ 2011-04-29 6:08 UTC (permalink / raw) To: Stephen Warren Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Hi, Stephen I think your patches address the different issues with my patches. My patches are used for retry transfer and new slave controller. Thanks Wei. -----Original Message----- From: Stephen Warren Sent: Thursday, April 28, 2011 12:29 AM To: Wei Ni Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Subject: RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > Hi, all > Could anyone review these changes? Wei, It looks like some of the patches I recently posted address the same issues as the patches you had already posted. Sorry for the potential conflicts. Can you please take a look at the patches I posted and comment on which of those are still relevant given your patches. Even for the cases where we both posted patches to address the same issue (e.g. use new slave mode), there are differences in the patches. I simply took the changes from the chromeos-2.6.37 kernel and cherry-picked them into the mainline kernel. Are the changes you posted re-written to address issues that weren't solved in the ChromeOS kernel? Thanks for any feedback on this. > > Thanks > Wei. > > -----Original Message----- > From: Wei Ni > Sent: Wednesday, April 20, 2011 8:09 PM > To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; > lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux- > i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Wei Ni > Subject: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c > > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > *** BLURB HERE *** > > Wei Ni (2): > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > i2c: tegra: use new i2c slave controller > > drivers/i2c/busses/i2c-tegra.c | 57 > +++++++++++++++++++++++++++++++++++++-- > include/linux/i2c-tegra.h | 3 ++ > 2 files changed, 57 insertions(+), 3 deletions(-) -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E2-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E2-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org> @ 2011-04-29 15:20 ` Stephen Warren [not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AEEF-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Stephen Warren @ 2011-04-29 15:20 UTC (permalink / raw) To: Wei Ni Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > Hi, all > > > Could anyone review these changes? > > > > Wei, > > > > It looks like some of the patches I recently posted address the same > > issues as the patches you had already posted. Sorry for the potential > > conflicts. > > Hi, Stephen > I think your patches address the different issues with my patches. > My patches are used for retry transfer and new slave controller. Wei, aren't the following two patches basically the same thing, except that yours also sets the slave address register, and is a bit more wordy: http://www.spinics.net/lists/linux-i2c/msg05464.html http://www.spinics.net/lists/linux-i2c/msg05437.html Upon further inspection, I don't think any of the other patches I posted conflict with the other patch you posted. > > Can you please take a look at the patches I posted and comment on which > > of those are still relevant given your patches. Even for the cases where > > we both posted patches to address the same issue (e.g. use new slave > > mode), there are differences in the patches. I simply took the changes > > from the chromeos-2.6.37 kernel and cherry-picked them into the mainline > > kernel. Are the changes you posted re-written to address issues that > > weren't solved in the ChromeOS kernel? > > > > Thanks for any feedback on this. Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > *** BLURB HERE *** > > Wei Ni (2): > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > i2c: tegra: use new i2c slave controller > > drivers/i2c/busses/i2c-tegra.c | 57 +++++++++++++++++++++++++++++++++++++-- > include/linux/i2c-tegra.h | 3 ++ > 2 files changed, 57 insertions(+), 3 deletions(-) -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <74CDBE0F657A3D45AFBB94109FB122FF0497F1AEEF-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AEEF-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> @ 2011-05-04 3:03 ` Wei Ni 2011-05-04 8:28 ` Marc Dietrich 0 siblings, 1 reply; 9+ messages in thread From: Wei Ni @ 2011-05-04 3:03 UTC (permalink / raw) To: Stephen Warren Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Hi, Stephen I think if doesn't need to apply the slave address codes, we can use your patch. Thanks Wei. -----Original Message----- From: Stephen Warren Sent: Friday, April 29, 2011 11:20 PM To: Wei Ni Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Subject: RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > Hi, all > > > Could anyone review these changes? > > > > Wei, > > > > It looks like some of the patches I recently posted address the same > > issues as the patches you had already posted. Sorry for the potential > > conflicts. > > Hi, Stephen > I think your patches address the different issues with my patches. > My patches are used for retry transfer and new slave controller. Wei, aren't the following two patches basically the same thing, except that yours also sets the slave address register, and is a bit more wordy: http://www.spinics.net/lists/linux-i2c/msg05464.html http://www.spinics.net/lists/linux-i2c/msg05437.html Upon further inspection, I don't think any of the other patches I posted conflict with the other patch you posted. > > Can you please take a look at the patches I posted and comment on which > > of those are still relevant given your patches. Even for the cases where > > we both posted patches to address the same issue (e.g. use new slave > > mode), there are differences in the patches. I simply took the changes > > from the chromeos-2.6.37 kernel and cherry-picked them into the mainline > > kernel. Are the changes you posted re-written to address issues that > > weren't solved in the ChromeOS kernel? > > > > Thanks for any feedback on this. Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > *** BLURB HERE *** > > Wei Ni (2): > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > i2c: tegra: use new i2c slave controller > > drivers/i2c/busses/i2c-tegra.c | 57 +++++++++++++++++++++++++++++++++++++-- > include/linux/i2c-tegra.h | 3 ++ > 2 files changed, 57 insertions(+), 3 deletions(-) -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c 2011-05-04 3:03 ` Wei Ni @ 2011-05-04 8:28 ` Marc Dietrich [not found] ` <201105041028.09316.marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Marc Dietrich @ 2011-05-04 8:28 UTC (permalink / raw) To: Wei Ni Cc: Stephen Warren, khali@linux-fr.org, ben-linux@fluff.org, lucas.demarchi@profusion.mobi, ccross@android.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Olof Johansson (olof@lixom.net) Wei, Stephen, > Hi, Stephen > I think if doesn't need to apply the slave address codes, we can use your > patch. we use the slave address as part of our nvec mfd driver in the ac100 project, so it would be nice to have this merged. Is there any other implemenation for a driver which actually use "is_slave"? (beside the one from the older android kernels)? Regards, Marc > Thanks > Wei. > > -----Original Message----- > From: Stephen Warren > Sent: Friday, April 29, 2011 11:20 PM > To: Wei Ni > Cc: khali@linux-fr.org; ben-linux@fluff.org; lucas.demarchi@profusion.mobi; > ccross@android.com; linux-i2c@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-tegra@vger.kernel.org; Olof Johansson > (olof@lixom.net) Subject: RE: [PATCH 0/2] i2c: tegra: add some new > features for tegra i2c > > Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > > Hi, all > > > > Could anyone review these changes? > > > > > > Wei, > > > > > > It looks like some of the patches I recently posted address the same > > > issues as the patches you had already posted. Sorry for the potential > > > conflicts. > > > > Hi, Stephen > > I think your patches address the different issues with my patches. > > My patches are used for retry transfer and new slave controller. > > Wei, aren't the following two patches basically the same thing, > except that yours also sets the slave address register, and is a bit > more wordy: > > http://www.spinics.net/lists/linux-i2c/msg05464.html > http://www.spinics.net/lists/linux-i2c/msg05437.html > > Upon further inspection, I don't think any of the other patches I > posted conflict with the other patch you posted. > > > > Can you please take a look at the patches I posted and comment on which > > > of those are still relevant given your patches. Even for the cases > > > where we both posted patches to address the same issue (e.g. use new > > > slave mode), there are differences in the patches. I simply took the > > > changes from the chromeos-2.6.37 kernel and cherry-picked them into > > > the mainline kernel. Are the changes you posted re-written to address > > > issues that weren't solved in the ChromeOS kernel? > > > > > > Thanks for any feedback on this. > > Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > > From: Wei Ni <wni@nvidia.com> > > > > *** BLURB HERE *** > > > > Wei Ni (2): > > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > > i2c: tegra: use new i2c slave controller > > > > drivers/i2c/busses/i2c-tegra.c | 57 > > +++++++++++++++++++++++++++++++++++++-- include/linux/i2c-tegra.h > > | 3 ++ > > 2 files changed, 57 insertions(+), 3 deletions(-) -- Dipl. Phys. Marc Dietrich Institut für Angewandte Physik - AG Kleinkühler - Justus-Liebig-Universität Gießen Heinrich-Buff-Ring 16 D-35392 Gießen Germany Tel. +49 641 99 33462 Fax. +49 641 99 33409 email: marc.dietrich@ap.physik.uni-giessen.de www: http://www.uni-giessen.de/cms/iap/ ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <201105041028.09316.marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org>]
* RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c [not found] ` <201105041028.09316.marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org> @ 2011-05-04 9:19 ` Wei Ni 0 siblings, 0 replies; 9+ messages in thread From: Wei Ni @ 2011-05-04 9:19 UTC (permalink / raw) To: 'Marc Dietrich' Cc: Stephen Warren, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Hi, Marc I think no other implementation. Thanks Wei. -----Original Message----- From: Marc Dietrich [mailto:Marc.Dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org] Sent: Wednesday, May 04, 2011 4:28 PM To: Wei Ni Cc: Stephen Warren; khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org; ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Olof Johansson (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Subject: Re: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c Wei, Stephen, > Hi, Stephen > I think if doesn't need to apply the slave address codes, we can use your > patch. we use the slave address as part of our nvec mfd driver in the ac100 project, so it would be nice to have this merged. Is there any other implemenation for a driver which actually use "is_slave"? (beside the one from the older android kernels)? Regards, Marc > Thanks > Wei. > > -----Original Message----- > From: Stephen Warren > Sent: Friday, April 29, 2011 11:20 PM > To: Wei Ni > Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org; ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org; lucas.demarchi@profusion.mobi; > ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Olof Johansson > (olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org) Subject: RE: [PATCH 0/2] i2c: tegra: add some new > features for tegra i2c > > Wei Ni wrote at Friday, April 29, 2011 12:08 AM: > > Stephen Warren wrote at Thursday, April 28, 2011 12:29 AM: > > > Wei Ni wrote at Wednesday, April 27, 2011 4:26 AM: > > > > Hi, all > > > > Could anyone review these changes? > > > > > > Wei, > > > > > > It looks like some of the patches I recently posted address the same > > > issues as the patches you had already posted. Sorry for the potential > > > conflicts. > > > > Hi, Stephen > > I think your patches address the different issues with my patches. > > My patches are used for retry transfer and new slave controller. > > Wei, aren't the following two patches basically the same thing, > except that yours also sets the slave address register, and is a bit > more wordy: > > http://www.spinics.net/lists/linux-i2c/msg05464.html > http://www.spinics.net/lists/linux-i2c/msg05437.html > > Upon further inspection, I don't think any of the other patches I > posted conflict with the other patch you posted. > > > > Can you please take a look at the patches I posted and comment on which > > > of those are still relevant given your patches. Even for the cases > > > where we both posted patches to address the same issue (e.g. use new > > > slave mode), there are differences in the patches. I simply took the > > > changes from the chromeos-2.6.37 kernel and cherry-picked them into > > > the mainline kernel. Are the changes you posted re-written to address > > > issues that weren't solved in the ChromeOS kernel? > > > > > > Thanks for any feedback on this. > > Wei Ni wrote at Wednesday, April 20, 2011 8:09 PM: > > From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > > > *** BLURB HERE *** > > > > Wei Ni (2): > > i2c: tegra: Retry transfer when unexpected/no_ack status is detected > > i2c: tegra: use new i2c slave controller > > > > drivers/i2c/busses/i2c-tegra.c | 57 > > +++++++++++++++++++++++++++++++++++++-- include/linux/i2c-tegra.h > > | 3 ++ > > 2 files changed, 57 insertions(+), 3 deletions(-) -- Dipl. Phys. Marc Dietrich Institut für Angewandte Physik - AG Kleinkühler - Justus-Liebig-Universität Gießen Heinrich-Buff-Ring 16 D-35392 Gießen Germany Tel. +49 641 99 33462 Fax. +49 641 99 33409 email: marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org www: http://www.uni-giessen.de/cms/iap/ ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-05-04 9:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-04 8:31 [PATCH 0/2] i2c: tegra: add some new features for tegra i2c Marvin
-- strict thread matches above, loose matches on Subject: below --
2011-04-20 12:08 wni-DDmLM1+adcrQT0dZR+AlfA
[not found] ` <1303301312-15302-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-04-27 10:25 ` Wei Ni
[not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4DB-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-04-27 16:29 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AAC4-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-04-29 6:08 ` Wei Ni
[not found] ` <6B4D417B830BC44B8026029FD256F7F1C2CB3DD4E2-Q4EWCATADntDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-04-29 15:20 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1AEEF-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-05-04 3:03 ` Wei Ni
2011-05-04 8:28 ` Marc Dietrich
[not found] ` <201105041028.09316.marc.dietrich-wkdnK3oF/XPYtB+G+YtuwQgYPMzSbZxj@public.gmane.org>
2011-05-04 9:19 ` Wei Ni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).