* [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
@ 2011-04-13 10:45 Mike Rapoport
[not found] ` <1302691521-19096-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2011-04-13 10:45 UTC (permalink / raw)
To: Ben Dooks
Cc: Colin Cross, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Mike Rapoport
as there are a lot of i2c device drivers that require it.
Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index b4ab39b..7e68f2c 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -495,7 +495,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
static u32 tegra_i2c_func(struct i2c_adapter *adap)
{
- return I2C_FUNC_I2C;
+ return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
}
static const struct i2c_algorithm tegra_i2c_algo = {
--
1.7.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
[not found] ` <1302691521-19096-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
@ 2011-05-03 8:37 ` Mike Rapoport
[not found] ` <4DBFBEAD.2080103-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Mike Rapoport @ 2011-05-03 8:37 UTC (permalink / raw)
To: Mike Rapoport
Cc: Ben Dooks, Colin Cross, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Hi Ben,
Any comments on this?
On 04/13/11 13:45, Mike Rapoport wrote:
> as there are a lot of i2c device drivers that require it.
>
> Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-tegra.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index b4ab39b..7e68f2c 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -495,7 +495,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
>
> static u32 tegra_i2c_func(struct i2c_adapter *adap)
> {
> - return I2C_FUNC_I2C;
> + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> }
>
> static const struct i2c_algorithm tegra_i2c_algo = {
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
[not found] ` <4DBFBEAD.2080103-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
@ 2011-05-03 19:57 ` Stephen Warren
2011-05-04 21:51 ` Ben Dooks
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2011-05-03 19:57 UTC (permalink / raw)
To: Mike Rapoport
Cc: Ben Dooks, Colin Cross,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Mike Rapoport wrote at Tuesday, May 03, 2011 2:37 AM:
> Hi Ben,
> Any comments on this?
Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
(on TrimSlice, I tested the audio driver, and validated that this patch
Was necessary and worked correctly)
> On 04/13/11 13:45, Mike Rapoport wrote:
> > as there are a lot of i2c device drivers that require it.
> >
> > Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> > ---
> > drivers/i2c/busses/i2c-tegra.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> > index b4ab39b..7e68f2c 100644
> > --- a/drivers/i2c/busses/i2c-tegra.c
> > +++ b/drivers/i2c/busses/i2c-tegra.c
> > @@ -495,7 +495,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
> >
> > static u32 tegra_i2c_func(struct i2c_adapter *adap)
> > {
> > - return I2C_FUNC_I2C;
> > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> > }
> >
> > static const struct i2c_algorithm tegra_i2c_algo = {
--
nvpublic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
[not found] ` <4DBFBEAD.2080103-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-05-03 19:57 ` Stephen Warren
@ 2011-05-04 21:51 ` Ben Dooks
[not found] ` <20110504215133.GY15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
1 sibling, 1 reply; 6+ messages in thread
From: Ben Dooks @ 2011-05-04 21:51 UTC (permalink / raw)
To: Mike Rapoport
Cc: Ben Dooks, Colin Cross, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
On Tue, May 03, 2011 at 11:37:01AM +0300, Mike Rapoport wrote:
> Hi Ben,
> Any comments on this?
>
> On 04/13/11 13:45, Mike Rapoport wrote:
> > as there are a lot of i2c device drivers that require it.
> >
> > Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> > ---
> > drivers/i2c/busses/i2c-tegra.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> > index b4ab39b..7e68f2c 100644
> > --- a/drivers/i2c/busses/i2c-tegra.c
> > +++ b/drivers/i2c/busses/i2c-tegra.c
> > @@ -495,7 +495,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
> >
> > static u32 tegra_i2c_func(struct i2c_adapter *adap)
> > {
> > - return I2C_FUNC_I2C;
> > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> > }
I think this is ok, but will check tomorrow
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
[not found] ` <20110504215133.GY15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
@ 2011-05-29 20:57 ` mike-UTxiZqZC01RS1MOuV/RT9w
2011-07-02 19:00 ` Mike Rapoport
1 sibling, 0 replies; 6+ messages in thread
From: mike-UTxiZqZC01RS1MOuV/RT9w @ 2011-05-29 20:57 UTC (permalink / raw)
To: Ben Dooks
Cc: Ben Dooks, Colin Cross, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA
Hi Ben,
On Wed, May 04, 2011 at 10:51:33PM +0100, Ben Dooks wrote:
> On Tue, May 03, 2011 at 11:37:01AM +0300, Mike Rapoport wrote:
> > Hi Ben,
> > Any comments on this?
> >
> > On 04/13/11 13:45, Mike Rapoport wrote:
> > > as there are a lot of i2c device drivers that require it.
> > >
> > > Signed-off-by: Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> > > ---
> > > drivers/i2c/busses/i2c-tegra.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
>
> I think this is ok, but will check tomorrow
Can you please merge this patch? So that it can hit the mainline at
leaset at 2.6.41?
> --
> Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
>
> Large Hadron Colada: A large Pina Colada that makes the universe disappear.
>
--
Sincerely yours,
Mike
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality
[not found] ` <20110504215133.GY15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-05-29 20:57 ` mike-UTxiZqZC01RS1MOuV/RT9w
@ 2011-07-02 19:00 ` Mike Rapoport
1 sibling, 0 replies; 6+ messages in thread
From: Mike Rapoport @ 2011-07-02 19:00 UTC (permalink / raw)
To: Ben Dooks
Cc: Mike Rapoport, Ben Dooks, Colin Cross,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA, Jean Delvare
Hi Ben,
On Thu, May 5, 2011 at 12:51 AM, Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote:
> On Tue, May 03, 2011 at 11:37:01AM +0300, Mike Rapoport wrote:
>> Hi Ben,
>> Any comments on this?
>>
>
> I think this is ok, but will check tomorrow
Any chance you can at last merge this patch?
--
Sincerely Yours,
Mike.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-02 19:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 10:45 [PATCH] i2c: tegra: add I2C_FUNC_SMBUS_EMUL to adapter functionality Mike Rapoport
[not found] ` <1302691521-19096-1-git-send-email-mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-05-03 8:37 ` Mike Rapoport
[not found] ` <4DBFBEAD.2080103-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2011-05-03 19:57 ` Stephen Warren
2011-05-04 21:51 ` Ben Dooks
[not found] ` <20110504215133.GY15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-05-29 20:57 ` mike-UTxiZqZC01RS1MOuV/RT9w
2011-07-02 19:00 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).