* [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF
@ 2011-04-11 8:34 Sebastian Andrzej Siewior
[not found] ` <20110411083447.GB4018-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2011-04-11 8:34 UTC (permalink / raw)
To: Ben Dooks (embedded platforms)
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Grant Likely
Since commit c9e358d ("driver-core: remove conditionals around
devicetree pointers") there is no need for CONFIG_OF around of_node and
of_match_table. Grant removed this ifdefs from all driver which were in
tree at the time, this one was merged later.
Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
---
drivers/i2c/busses/i2c-pxa.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index f59224a..91c4c15 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1138,9 +1138,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
i2c->adap.algo_data = i2c;
i2c->adap.dev.parent = &dev->dev;
-#ifdef CONFIG_OF
i2c->adap.dev.of_node = dev->dev.of_node;
-#endif
if (i2c_type == REGS_CE4100)
ret = i2c_add_adapter(&i2c->adap);
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF
[not found] ` <20110411083447.GB4018-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
@ 2011-05-03 13:58 ` Grant Likely
[not found] ` <20110503135826.GA4966-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2011-05-03 13:58 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Ben Dooks (embedded platforms), linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Mon, Apr 11, 2011 at 10:34:47AM +0200, Sebastian Andrzej Siewior wrote:
> Since commit c9e358d ("driver-core: remove conditionals around
> devicetree pointers") there is no need for CONFIG_OF around of_node and
> of_match_table. Grant removed this ifdefs from all driver which were in
> tree at the time, this one was merged later.
>
> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Hey Ben,
Can you pick up this patch?
Thanks,
g.
> ---
> drivers/i2c/busses/i2c-pxa.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> index f59224a..91c4c15 100644
> --- a/drivers/i2c/busses/i2c-pxa.c
> +++ b/drivers/i2c/busses/i2c-pxa.c
> @@ -1138,9 +1138,7 @@ static int i2c_pxa_probe(struct platform_device *dev)
>
> i2c->adap.algo_data = i2c;
> i2c->adap.dev.parent = &dev->dev;
> -#ifdef CONFIG_OF
> i2c->adap.dev.of_node = dev->dev.of_node;
> -#endif
>
> if (i2c_type == REGS_CE4100)
> ret = i2c_add_adapter(&i2c->adap);
> --
> 1.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF
[not found] ` <20110503135826.GA4966-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
@ 2011-05-04 21:52 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2011-05-04 21:52 UTC (permalink / raw)
To: Grant Likely
Cc: Sebastian Andrzej Siewior, Ben Dooks (embedded platforms),
linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Tue, May 03, 2011 at 07:58:26AM -0600, Grant Likely wrote:
> On Mon, Apr 11, 2011 at 10:34:47AM +0200, Sebastian Andrzej Siewior wrote:
> > Since commit c9e358d ("driver-core: remove conditionals around
> > devicetree pointers") there is no need for CONFIG_OF around of_node and
> > of_match_table. Grant removed this ifdefs from all driver which were in
> > tree at the time, this one was merged later.
> >
> > Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
>
> Hey Ben,
>
> Can you pick up this patch?
ok, will sort this out.
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-04 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-11 8:34 [REPOST PATCH] i2c: pxa2xx: remove ifdef CONFIG_OF Sebastian Andrzej Siewior
[not found] ` <20110411083447.GB4018-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2011-05-03 13:58 ` Grant Likely
[not found] ` <20110503135826.GA4966-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-05-04 21:52 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).