From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mohan Pallaka <mpallaka@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.intradead.org,
linux-input@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations
Date: Sun, 15 May 2011 11:58:50 +0100 [thread overview]
Message-ID: <20110515105850.GH30539@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110515080031.GA12911@core.coreip.homeip.net>
On Sun, May 15, 2011 at 01:00:31AM -0700, Dmitry Torokhov wrote:
> On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote:
> > For chip drivers that support both pwm and non-pwm modes
> > would encounter compilation errors if the platform doesn't
> > have support for pwm though the chip is programmed to work
> > in non-pwm mode. Add __weak attributed pwm functions to avoid
> > compilation issues in these scenarios.
> >
>
> Russell,
>
> You seem to have authored pwm.h, do you have any objections to this
> change?
This seems to be a recipe for an oops. Have a look at how
linux/regulator/consumer.h deals with this kind of problem, and notice
that we have CONFIG_HAVE_PWM to indicate whether this interface is
supported or not.
next prev parent reply other threads:[~2011-05-15 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 12:43 [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
2011-05-13 12:43 ` [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations Mohan Pallaka
2011-05-13 16:25 ` David Brown
2011-05-15 8:00 ` Dmitry Torokhov
2011-05-15 10:58 ` Russell King - ARM Linux [this message]
[not found] ` <20110515105850.GH30539-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2011-05-17 4:42 ` Mohan Pallaka
2011-05-15 8:16 ` Dmitry Torokhov
[not found] ` <1305290602-29859-1-git-send-email-mpallaka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-13 12:43 ` [PATCH 2/2] input: misc: Add support for isa1200 chip Mohan Pallaka
-- strict thread matches above, loose matches on Subject: below --
2011-04-13 12:25 [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
[not found] ` <1302697533-20456-1-git-send-email-mpallaka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-04-13 12:25 ` [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations Mohan Pallaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110515105850.GH30539@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.intradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpallaka@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).