From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] leds: pca9532: change driver name to be unique Date: Thu, 30 Jun 2011 16:06:15 +0200 Message-ID: <20110630160615.516c456a@endymion.delvare> References: <1309440981-18861-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1309440981-18861-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Riku Voipio , Richard Purdie List-Id: linux-i2c@vger.kernel.org On Thu, 30 Jun 2011 15:36:21 +0200, Wolfram Sang wrote: > This driver handles the variants pca9530-pca9533, so it chose the name > "pca953x". However, there is a gpio driver which decided on the same > name. As a result, those two can't be loaded at the same time. Add a > subsystem prefix to make the driver name unique. Device matching will > not suffer, because both are I2C drivers which match using a > i2c_device_id-table which is not altered. > > Signed-off-by: Wolfram Sang Which is (one of the reasons) why I hate "x" in driver names. Acked-by: Jean Delvare > --- > drivers/leds/leds-pca9532.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c > index d8d3a1e..a2c8746 100644 > --- a/drivers/leds/leds-pca9532.c > +++ b/drivers/leds/leds-pca9532.c > @@ -88,7 +88,7 @@ static const struct pca9532_chip_info pca9532_chip_info_tbl[] = { > > static struct i2c_driver pca9532_driver = { > .driver = { > - .name = "pca953x", > + .name = "leds-pca953x", > }, > .probe = pca9532_probe, > .remove = pca9532_remove, -- Jean Delvare