From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dirk Brandewie
<dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
John Bonesio <bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Stephen Warren <SWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus id.
Date: Tue, 5 Jul 2011 10:53:30 +0200 [thread overview]
Message-ID: <20110705105330.63c113c8@endymion.delvare> (raw)
In-Reply-To: <BANLkTi=6zxPUwGZ5JHhRGRHHaEgvNgiaHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Grant,
Sorry for the late answer.
On Mon, 27 Jun 2011 13:02:45 -0600, Grant Likely wrote:
> On Mon, Jun 27, 2011 at 12:55 PM, Grant Likely
> <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:
> > Currently, if an i2c bus driver supports both static and dynamic bus
> > ids, it needs to choose between calling i2c_add_numbered_adapter() and
> > i2c_add_adapter(). This patch makes i2c_add_numbered_adapter()
> > redirect to i2c_add_adapter() if the requested bus id is -1.
> >
> > Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>
> Oops, forgot to edit the email before sending the patch.
>
> This patch is as-yet untested other than build testing, but I want to
> get feedback. With the move to DT on ARM, there are going to be a lot
> more i2c bus drivers that need to support both static and dynamically
> allocated busses, and it is very likely that it will be needed in the
> v3.1 merge window.
>
> Ben/Jean, *IF* this patch tests out okay, and *IF* I get an ack from
> you, it will probably need to have this commit in my devicetree/next
> branch. If so, then I'll either need to commit it myself, or have it
> put into a separate topic branch that both of us can merge into our
> trees. What is your preference.
>
> John: this is the patch that I asked you to write earlier today, but I
> think one of the TI folks will run into the same issue, so I wanted to
> get it drafted and onto the list ASAP.
If this makes your life easier then I have no objection, you can go
ahead. I don't expect any conflict with my tree as there is no i2c-core
work going on on my end at the moment. So you can just take it in your
tree and merge it yourself as you see fit.
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
--
Jean Delvare
next prev parent reply other threads:[~2011-07-05 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 18:55 [PATCH] i2c: Allow i2c_add_numbered_adapter() to assign a bus id Grant Likely
2011-06-27 19:02 ` Grant Likely
[not found] ` <BANLkTi=6zxPUwGZ5JHhRGRHHaEgvNgiaHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-05 8:53 ` Jean Delvare [this message]
[not found] ` <20110705105330.63c113c8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-05 13:31 ` Grant Likely
2011-07-06 6:37 ` Grant Likely
[not found] ` <20110706063746.GA26611-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-07-06 7:51 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705105330.63c113c8@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=SWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=bones-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).