From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] power: Remove obsolete cleanup for clientdata Date: Fri, 8 Jul 2011 17:10:49 +0400 Message-ID: <20110708131049.GD29056@oksana.dev.rtsoft.ru> References: <1308603674-19264-1-git-send-email-w.sang@pengutronix.de> <1308603674-19264-3-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, MyungJoo Ham , Kyungmin Park List-Id: linux-i2c@vger.kernel.org On Mon, Jun 20, 2011 at 11:01:14PM +0200, Wolfram Sang wrote: > A few new i2c-drivers came into the kernel which clear the clientdata-pointer > on exit or error. This is obsolete meanwhile, the core will do it. > > Signed-off-by: Wolfram Sang > Cc: MyungJoo Ham > Cc: Anton Vorontsov > Cc: Kyungmin Park > --- > > This is more a cleanup than a bugfix. Still, would be happy to have this > obsolete programming style largely removed in 3.0 if possible. Applied for 3.1, sorry. This is not a regression fix. Thanks, > > drivers/power/max17042_battery.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c > index c5c8805..09f7496 100644 > --- a/drivers/power/max17042_battery.c > +++ b/drivers/power/max17042_battery.c > @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client, > ret = power_supply_register(&client->dev, &chip->battery); > if (ret) { > dev_err(&client->dev, "failed: power supply register\n"); > - i2c_set_clientdata(client, NULL); > kfree(chip); > return ret; > } > @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client) > struct max17042_chip *chip = i2c_get_clientdata(client); > > power_supply_unregister(&chip->battery); > - i2c_set_clientdata(client, NULL); > kfree(chip); > return 0; > } -- Anton Vorontsov Email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org