[PATCH] input/keyboard: Remove obsolete cleanup for clientdata

[PATCH] input/keyboard: Remove obsolete cleanup for clientdata

[Wolfram Sang]

A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---

This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.

 drivers/input/keyboard/qt1070.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index ca7b891..b21bf5b 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client)
 	input_unregister_device(data->input);
 	kfree(data);
 
-	i2c_set_clientdata(client, NULL);
-
 	return 0;
 }
 
-- 
1.7.2.5

[PATCH] leds: Remove obsolete cleanup for clientdata

[Wolfram Sang]

A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
---

This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.

 drivers/leds/leds-lm3530.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
index 4d7ce76..59f5604 100644
--- a/drivers/leds/leds-lm3530.c
+++ b/drivers/leds/leds-lm3530.c
@@ -382,7 +382,6 @@ err_class_register:
 err_reg_init:
 	regulator_put(drvdata->regulator);
 err_regulator_get:
-	i2c_set_clientdata(client, NULL);
 	kfree(drvdata);
 err_out:
 	return err;
-- 
1.7.2.5

Re: [PATCH] leds: Remove obsolete cleanup for clientdata

[Jean Delvare]

On Mon, 20 Jun 2011 23:01:13 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

> ---
> 
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
> 
>  drivers/leds/leds-lm3530.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
> index 4d7ce76..59f5604 100644
> --- a/drivers/leds/leds-lm3530.c
> +++ b/drivers/leds/leds-lm3530.c
> @@ -382,7 +382,6 @@ err_class_register:
>  err_reg_init:
>  	regulator_put(drvdata->regulator);
>  err_regulator_get:
> -	i2c_set_clientdata(client, NULL);
>  	kfree(drvdata);
>  err_out:
>  	return err;


-- 
Jean Delvare

[PATCH] power: Remove obsolete cleanup for clientdata

[Wolfram Sang]

A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.

Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---

This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.

 drivers/power/max17042_battery.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index c5c8805..09f7496 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
 	ret = power_supply_register(&client->dev, &chip->battery);
 	if (ret) {
 		dev_err(&client->dev, "failed: power supply register\n");
-		i2c_set_clientdata(client, NULL);
 		kfree(chip);
 		return ret;
 	}
@@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
 	struct max17042_chip *chip = i2c_get_clientdata(client);
 
 	power_supply_unregister(&chip->battery);
-	i2c_set_clientdata(client, NULL);
 	kfree(chip);
 	return 0;
 }
-- 
1.7.2.5

Re: [PATCH] power: Remove obsolete cleanup for clientdata

[Jean Delvare]

On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

> ---
> 
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
> 
>  drivers/power/max17042_battery.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index c5c8805..09f7496 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
>  	ret = power_supply_register(&client->dev, &chip->battery);
>  	if (ret) {
>  		dev_err(&client->dev, "failed: power supply register\n");
> -		i2c_set_clientdata(client, NULL);
>  		kfree(chip);
>  		return ret;
>  	}
> @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
>  	struct max17042_chip *chip = i2c_get_clientdata(client);
>  
>  	power_supply_unregister(&chip->battery);
> -	i2c_set_clientdata(client, NULL);
>  	kfree(chip);
>  	return 0;
>  }


-- 
Jean Delvare

Re: [PATCH] power: Remove obsolete cleanup for clientdata

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]

On Tue, Jun 21, 2011 at 10:54:56AM +0200, Jean Delvare wrote:
> On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> > 
> > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> 
> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

Anton, can you pick it for 3.1?

> 
> > ---
> > 
> > This is more a cleanup than a bugfix. Still, would be happy to have this
> > obsolete programming style largely removed in 3.0 if possible.
> > 
> >  drivers/power/max17042_battery.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> > index c5c8805..09f7496 100644
> > --- a/drivers/power/max17042_battery.c
> > +++ b/drivers/power/max17042_battery.c
> > @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
> >  	ret = power_supply_register(&client->dev, &chip->battery);
> >  	if (ret) {
> >  		dev_err(&client->dev, "failed: power supply register\n");
> > -		i2c_set_clientdata(client, NULL);
> >  		kfree(chip);
> >  		return ret;
> >  	}
> > @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
> >  	struct max17042_chip *chip = i2c_get_clientdata(client);
> >  
> >  	power_supply_unregister(&chip->battery);
> > -	i2c_set_clientdata(client, NULL);
> >  	kfree(chip);
> >  	return 0;
> >  }
> 
> 
> -- 
> Jean Delvare
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] power: Remove obsolete cleanup for clientdata

[Anton Vorontsov]

On Fri, Jul 08, 2011 at 11:15:56AM +0200, Wolfram Sang wrote:
> On Tue, Jun 21, 2011 at 10:54:56AM +0200, Jean Delvare wrote:
> > On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> > > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > > on exit or error. This is obsolete meanwhile, the core will do it.
> > > 
> > > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > 
> > Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> 
> Anton, can you pick it for 3.1?

Will do. Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Re: [PATCH] power: Remove obsolete cleanup for clientdata

[Anton Vorontsov]

On Mon, Jun 20, 2011 at 11:01:14PM +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> 
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.

Applied for 3.1, sorry. This is not a regression fix.

Thanks,

> 
>  drivers/power/max17042_battery.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index c5c8805..09f7496 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
>  	ret = power_supply_register(&client->dev, &chip->battery);
>  	if (ret) {
>  		dev_err(&client->dev, "failed: power supply register\n");
> -		i2c_set_clientdata(client, NULL);
>  		kfree(chip);
>  		return ret;
>  	}
> @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
>  	struct max17042_chip *chip = i2c_get_clientdata(client);
>  
>  	power_supply_unregister(&chip->battery);
> -	i2c_set_clientdata(client, NULL);
>  	kfree(chip);
>  	return 0;
>  }

-- 
Anton Vorontsov
Email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Re: [PATCH] power: Remove obsolete cleanup for clientdata

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Fri, Jul 08, 2011 at 05:10:49PM +0400, Anton Vorontsov wrote:
> On Mon, Jun 20, 2011 at 11:01:14PM +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> > 
> > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> > 
> > This is more a cleanup than a bugfix. Still, would be happy to have this
> > obsolete programming style largely removed in 3.0 if possible.
> 
> Applied for 3.1, sorry. This is not a regression fix.

3.1 is fine, too. Thanks!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata

[Jean Delvare]

On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

> ---
> 
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
> 
>  drivers/input/keyboard/qt1070.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
> index ca7b891..b21bf5b 100644
> --- a/drivers/input/keyboard/qt1070.c
> +++ b/drivers/input/keyboard/qt1070.c
> @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client)
>  	input_unregister_device(data->input);
>  	kfree(data);
>  
> -	i2c_set_clientdata(client, NULL);
> -
>  	return 0;
>  }
>  


-- 
Jean Delvare

Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata

[Dmitry Torokhov]

On Tue, Jun 21, 2011 at 10:55:32AM +0200, Jean Delvare wrote:
> On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> > 
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Bo Shen <voice.shen@atmel.com>
> > Cc: Axel Lin <axel.lin@gmail.com>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 

Applied, thanks Wolfram.

-- 
Dmitry