From: Tony Lindgren <tony@atomide.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
"G, Manjunath Kondaiah" <manjugk@linaro.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
ben-linux@fluff.org, patches@linaro.org
Subject: Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine
Date: Fri, 22 Jul 2011 00:12:49 -0700 [thread overview]
Message-ID: <20110722071249.GK5783@atomide.com> (raw)
In-Reply-To: <CAC63_iQcia64iBq653S+3_Yj8mgfbGSfHdGXevFe8urj9RpF-w@mail.gmail.com>
* G, Manjunath Kondaiah <manjugk@ti.com> [110719 09:59]:
> On Tue, Jul 19, 2011 at 2:00 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> >
> > No, the i2c bus node should still appear in the SoC .dtsi file. If a
> > board doesn't use a particular i2c bus, then the board.dts file can
> > add a status = "disabled"; property to the i2c bus node to disable it.
>
> that's right. I am referring to I2C slave devices. For a given SoC,
> two different
> boards can have different i2c slave devices with different slave
> address. In that case,
> it is better to have i2c child/slave nodes in board .dts file.
This is OK for now, but from bus/hwmod point of view we need to reset all
the unused devices as otherwise PM will never work properly.
Disabling each device in the board .dts file will never be done correctly
for most boards.. And on each board, probably 2/3 of the devices are unused
because of the pin limitations :)
So the disabling of unused devices should be done with a late_initcall and
controlled by kernel cmdline. We were thinking hwmod.disable=[0|1].
The late_initcall to disable unused device tree devices could also be
added later on to device tree core code.
Regards,
Tony
prev parent reply other threads:[~2011-07-22 7:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 0:50 [PATCH 0/2] Add device tree support for Samsung's I2C driver Thomas Abraham
[not found] ` <1310950241-13602-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-18 0:50 ` [PATCH 1/2] i2c: s3c24xx: Add device tree support Thomas Abraham
[not found] ` <1310950241-13602-2-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-18 4:28 ` Grant Likely
2011-07-18 0:50 ` [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine Thomas Abraham
2011-07-18 4:30 ` Grant Likely
2011-07-18 9:45 ` Ben Dooks
[not found] ` <20110718094534.GN15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-07-18 20:28 ` Grant Likely
2011-07-18 11:53 ` G, Manjunath Kondaiah
2011-07-18 20:30 ` Grant Likely
2011-07-19 17:05 ` G, Manjunath Kondaiah
2011-07-22 7:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722071249.GK5783@atomide.com \
--to=tony@atomide.com \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=manjugk@linaro.org \
--cc=manjugk@ti.com \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).