* [PATCH -next] i2c: i2c-pxa-pci.c needs module.h [not found] <20110729173827.716f57ff6e00095a3efc6449@canb.auug.org.au> @ 2011-07-30 4:14 ` Randy Dunlap [not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2011-07-30 4:14 UTC (permalink / raw) To: Stephen Rothwell, linux-i2c, akpm; +Cc: linux-next, LKML, khali, ben-linux From: Randy Dunlap <rdunlap@xenotime.net> i2c-pxa-pci.c uses interfaces from linux/module.h, so it should include that file. This fixes build errors. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> --- drivers/i2c/busses/i2c-pxa-pci.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c @@ -3,6 +3,7 @@ * It does not support slave mode, the register slightly moved. This PCI * device provides three bars, every contains a single I2C controller. */ +#include <linux/module.h> #include <linux/pci.h> #include <linux/platform_device.h> #include <linux/i2c/pxa-i2c.h> ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>]
* Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h [not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> @ 2011-07-30 19:09 ` Paul Gortmaker 2011-07-31 16:42 ` Ben Dooks 0 siblings, 1 reply; 4+ messages in thread From: Paul Gortmaker @ 2011-07-30 19:09 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, linux-i2c-u79uwXL29TY76Z2rM5mHXA, akpm, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML, khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote: > From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> > > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should > include that file. This fixes build errors. Applied to module.h-split, thanks. P. > > Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> > --- > drivers/i2c/busses/i2c-pxa-pci.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c > @@ -3,6 +3,7 @@ > * It does not support slave mode, the register slightly moved. This PCI > * device provides three bars, every contains a single I2C controller. > */ > +#include <linux/module.h> > #include <linux/pci.h> > #include <linux/platform_device.h> > #include <linux/i2c/pxa-i2c.h> > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h 2011-07-30 19:09 ` Paul Gortmaker @ 2011-07-31 16:42 ` Ben Dooks [not found] ` <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Ben Dooks @ 2011-07-31 16:42 UTC (permalink / raw) To: Paul Gortmaker Cc: Randy Dunlap, Stephen Rothwell, linux-i2c, akpm, linux-next, LKML, khali, ben-linux On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote: > On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap@xenotime.net> wrote: > > From: Randy Dunlap <rdunlap@xenotime.net> > > > > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should > > include that file. This fixes build errors. > > Applied to module.h-split, thanks. ok, so I don't need to apply this one? Acked-by: Ben Dooks <ben-linux@fluff.org> > P. > > > > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> > > --- > > drivers/i2c/busses/i2c-pxa-pci.c | 1 + > > 1 file changed, 1 insertion(+) > > > > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c > > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c > > @@ -3,6 +3,7 @@ > > * It does not support slave mode, the register slightly moved. This PCI > > * device provides three bars, every contains a single I2C controller. > > */ > > +#include <linux/module.h> > > #include <linux/pci.h> > > #include <linux/platform_device.h> > > #include <linux/i2c/pxa-i2c.h> > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-next" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>]
* Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h [not found] ` <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> @ 2011-07-31 19:41 ` Paul Gortmaker 0 siblings, 0 replies; 4+ messages in thread From: Paul Gortmaker @ 2011-07-31 19:41 UTC (permalink / raw) To: Ben Dooks Cc: Randy Dunlap, Stephen Rothwell, linux-i2c-u79uwXL29TY76Z2rM5mHXA, akpm, linux-next-u79uwXL29TY76Z2rM5mHXA, LKML, khali-PUYAD+kWke1g9hUCZPvPmw, ben-linux-elnMNo+KYs3YtjvyW6yDsg On Sun, Jul 31, 2011 at 12:42 PM, Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote: > On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote: >> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> wrote: >> > From: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> >> > >> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should >> > include that file. This fixes build errors. >> >> Applied to module.h-split, thanks. > > ok, so I don't need to apply this one? Nope, I've got it. There are so many implicit module.h uses, that while farming them all out to subtrees could in theory be done, it really isn't all that practical (or timely). Thanks, Paul. > Acked-by: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> > >> P. >> >> > >> > Signed-off-by: Randy Dunlap <rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org> >> > --- >> > drivers/i2c/busses/i2c-pxa-pci.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c >> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c >> > @@ -3,6 +3,7 @@ >> > * It does not support slave mode, the register slightly moved. This PCI >> > * device provides three bars, every contains a single I2C controller. >> > */ >> > +#include <linux/module.h> >> > #include <linux/pci.h> >> > #include <linux/platform_device.h> >> > #include <linux/i2c/pxa-i2c.h> >> > -- >> > To unsubscribe from this list: send the line "unsubscribe linux-next" in >> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> > More majordomo info at http://vger.kernel.org/majordomo-info.html >> > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/ > > Large Hadron Colada: A large Pina Colada that makes the universe disappear. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-31 19:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110729173827.716f57ff6e00095a3efc6449@canb.auug.org.au>
2011-07-30 4:14 ` [PATCH -next] i2c: i2c-pxa-pci.c needs module.h Randy Dunlap
[not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-07-30 19:09 ` Paul Gortmaker
2011-07-31 16:42 ` Ben Dooks
[not found] ` <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-07-31 19:41 ` Paul Gortmaker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).