From: Ben Dooks <ben-i2c@fluff.org>
To: Paul Gortmaker <paul.gortmaker@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-i2c@vger.kernel.org, akpm <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
khali@linux-fr.org, ben-linux@fluff.org
Subject: Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h
Date: Sun, 31 Jul 2011 17:42:08 +0100 [thread overview]
Message-ID: <20110731164208.GP15795@trinity.fluff.org> (raw)
In-Reply-To: <CAP=VYLrtumuSM_ncO6sEr7=HciiKcOsB=yN4NZnAxesjSSOgMw@mail.gmail.com>
On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote:
> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
> > include that file. This fixes build errors.
>
> Applied to module.h-split, thanks.
ok, so I don't need to apply this one?
Acked-by: Ben Dooks <ben-linux@fluff.org>
> P.
>
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> > drivers/i2c/busses/i2c-pxa-pci.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
> > @@ -3,6 +3,7 @@
> > * It does not support slave mode, the register slightly moved. This PCI
> > * device provides three bars, every contains a single I2C controller.
> > */
> > +#include <linux/module.h>
> > #include <linux/pci.h>
> > #include <linux/platform_device.h>
> > #include <linux/i2c/pxa-i2c.h>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-07-31 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110729173827.716f57ff6e00095a3efc6449@canb.auug.org.au>
2011-07-30 4:14 ` [PATCH -next] i2c: i2c-pxa-pci.c needs module.h Randy Dunlap
[not found] ` <20110729211430.6c4830bd.rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2011-07-30 19:09 ` Paul Gortmaker
2011-07-31 16:42 ` Ben Dooks [this message]
[not found] ` <20110731164208.GP15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-07-31 19:41 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110731164208.GP15795@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).