From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT Date: Tue, 16 Aug 2011 19:50:33 +0200 Message-ID: <20110816195033.014f302b@endymion.delvare> References: <1312802446-19154-1-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1312802446-19154-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Hans Berglund , Jonas Bonn , Arnd Bergmann , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hi Geert, On Mon, 8 Aug 2011 13:20:46 +0200, Geert Uytterhoeven wrote: > On m68k, I get: >=20 > drivers/i2c/busses/i2c-elektor.c: In function =E2=80=98pcf_isa_init=E2= =80=99: > drivers/i2c/busses/i2c-elektor.c:153: error: implicit declaration of = function =E2=80=98ioport_map=E2=80=99 > drivers/i2c/busses/i2c-elektor.c:153: warning: assignment makes point= er from integer without a cast > drivers/i2c/busses/i2c-elektor.c: In function =E2=80=98elektor_probe=E2= =80=99: > drivers/i2c/busses/i2c-elektor.c:287: error: implicit declaration of = function =E2=80=98ioport_unmap=E2=80=99 >=20 > Since commit 82ed223c264def2b15ee4bec2e8c3048092ceb5f ("iomap: make I= OPORT/PCI > mapping functions conditional"), ioport_map() is only available on pl= atforms > that set HAS_IOPORT. >=20 > Signed-off-by: Geert Uytterhoeven > --- > drivers/i2c/busses/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 646068e..d1fc5cf 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -789,7 +789,7 @@ config I2C_ACORN > =20 > config I2C_ELEKTOR > tristate "Elektor ISA card" > - depends on ISA && BROKEN_ON_SMP > + depends on ISA && HAS_IOPORT && BROKEN_ON_SMP > select I2C_ALGOPCF > help > This supports the PCF8584 ISA bus I2C adapter. Say Y if you own How can ISA be set if HAS_IOPORT is not? This shouldn't be allowed. --=20 Jean Delvare