linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	Dilan Lee <dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Colin Cross <ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] i2c/tegra: I2C driver uses the suspend_noirq/resume_noirq
Date: Wed, 31 Aug 2011 17:31:29 +0100	[thread overview]
Message-ID: <20110831163129.GY2061@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201108311828.40783.arnd-r2nGTMty4D4@public.gmane.org>

On Wed, Aug 31, 2011 at 06:28:40PM +0200, Arnd Bergmann wrote:

> Sorry, I normally like to give my opinion on everything, but I really don't
> have a clue what this one is about. I don't understand i2c or power management ;-)

The issue is that due to our sequencing suspend and resume using the
control heirachy rather than dependencies we attempt to suspend the I2C
controller prior to some devices that need it.  As we don't have a good
solution for this at the minute where it's an issue we've been avoiding
it by using the _noirq() suspend and resume functions for the controller
to reorder their suspend with respect to the rest of the system.  It's
not great but practically speaking it works.

  parent reply	other threads:[~2011-08-31 16:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05 23:15 [PATCH] i2c/tegra: I2C driver uses the suspend_noirq/resume_noirq Stephen Warren
2011-08-06  4:33 ` Colin Cross
     [not found]   ` <CAMbhsRScgMaTZ2e3a__OgOrrA6HN9_dkGuuNGaEfP+iqRdjyNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-06  8:48     ` Mark Brown
     [not found]       ` <20110806084805.GA18098-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-08-11 19:35         ` Stephen Warren
     [not found]           ` <74CDBE0F657A3D45AFBB94109FB122FF04AEA24CC8-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-11 20:51             ` Colin Cross
     [not found]               ` <CAMbhsRR2+bhpjhGfUSt9M5tDk1EW2d70yC-tZy27zEgVqtkfSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 21:09                 ` Stephen Warren
     [not found]                   ` <74CDBE0F657A3D45AFBB94109FB122FF04AEA24D09-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-11 21:43                     ` Colin Cross
     [not found]                       ` <CAMbhsRTVm+dUODDgqiekpTrrNnpo9trJNNvOQ2ETCNkneh-L-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-12  0:45                         ` Mark Brown
     [not found]                           ` <1313109916.19990.28.camel-bheZrs9scGZIiRQ44+TIyueM+bqZidxxUxDKcUsq0RM@public.gmane.org>
2011-08-12  2:59                             ` Colin Cross
     [not found]                               ` <CAMbhsRShLvyc2XKJAL8PwR0Uj4Pnp9rVt7QyK1qAVxJ-R2PSdQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-12  3:14                                 ` Mark Brown
     [not found]                                   ` <20110812031433.GE10218-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-08-24 21:28                                     ` Stephen Warren
     [not found]                                       ` <74CDBE0F657A3D45AFBB94109FB122FF04B24A3CA6-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-24 21:33                                         ` Colin Cross
     [not found]                                           ` <CAMbhsRRRa_JV8_LHEvsM2h3e8Hbf1GAcpXz8gdU3wCc8Jgz5gw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-30 16:25                                             ` Stephen Warren
     [not found]                                               ` <74CDBE0F657A3D45AFBB94109FB122FF04B3279D4F-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-08-31 16:28                                                 ` Arnd Bergmann
     [not found]                                                   ` <201108311828.40783.arnd-r2nGTMty4D4@public.gmane.org>
2011-08-31 16:31                                                     ` Mark Brown [this message]
2011-09-20 16:51                                                 ` Stephen Warren
     [not found]                                                   ` <74CDBE0F657A3D45AFBB94109FB122FF04B73215C9-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-09-22 15:28                                                     ` Arnd Bergmann
2011-08-25 10:36                                         ` Mark Brown
2011-08-12  0:18                     ` Mark Brown
     [not found] ` <1312586102-27907-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-09-22 17:01   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110831163129.GY2061@opensource.wolfsonmicro.com \
    --to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=dilee-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).