From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH REPOST 2/2] i2c-imx: add device tree probe support Date: Fri, 9 Sep 2011 09:18:45 +0200 Message-ID: <20110909071845.GI28816@pengutronix.de> References: <1315465775-31335-1-git-send-email-shawn.guo@linaro.org> <1315465775-31335-3-git-send-email-shawn.guo@linaro.org> <4E69A0AE.1060004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <4E69A0AE.1060004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Shawn Guo , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Darius Augulis , Ben Dooks List-Id: linux-i2c@vger.kernel.org Hello Rob, On Fri, Sep 09, 2011 at 12:14:22AM -0500, Rob Herring wrote: > > +i2c@83fc4000 { /* I2C2 on i.MX51 */ > > + compatible =3D "fsl,imx51-i2c", "fsl,imx1-i2c"; > > + reg =3D <0x83fc4000 0x4000>; > > + interrupts =3D <63>; > > +}; > > + > > +i2c@70038000 { /* HS-I2C on i.MX51 */ >=20 > The mainline driver doesn't support the HS-I2C block does it? >=20 > The high speed and "old" i2c blocks on MX51 are basically different > blocks, so the compatible property should be different. I stumbled about that recently, too and found in arch/arm/plat-mxc/devices/platform-imx-i2c.c that the third device description for imx51 is a normal "imx-i2c" one using MX51_HSI2C_DMA_BASE_ADDR. So I concluded it's different but compatible. board-mx51_babbage.c uses imx51_add_hsi2c but doesn't add a bus description. So It might not attract attention if the driver doesn't match the device. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |