From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] i2c-tegra: Use the suspend_noirq/resume_noirq not suspend/resume Date: Thu, 22 Sep 2011 19:13:13 +0100 Message-ID: <20110922181313.GG5173@opensource.wolfsonmicro.com> References: <1316713892-357-1-git-send-email-swarren@nvidia.com> <20110922180335.GQ17168@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20110922180335.GQ17168-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Cc: Stephen Warren , Ben Dooks , Arnd Bergmann , Colin Cross , Olof Johansson , Erik Gilling , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dilan Lee List-Id: linux-i2c@vger.kernel.org On Thu, Sep 22, 2011 at 12:03:35PM -0600, Grant Likely wrote: > On Thu, Sep 22, 2011 at 11:51:32AM -0600, Stephen Warren wrote: > > * Implement an explicit dependency management system within the kernel for > > device suspend/resume, such that I2C bus would not be suspended before > > the sound card that requires it. It is reported that Linus rejected this > > proposal since he wanted suspend ordering to be based on probe ordering. > This really should be revisted. That was in the context of full > system suspend, but we're now in a world of runtime suspend which > absolutely does need dependency tracking or reference counting to get > the ordering right. FWIW this was one of the bigger issues in the PM miniconference in Santa Rosa, though a lot of the discission involved explaining the issues to some of the x86 guys and there wasn't mssive progress on solutions. > > * Enhance device probing such that the ASoC sound card device could defer > > its probing until all required resources were available. This would > > then cause the overall sound card suspend to occur at an appropriate early > > time. Grant Likely was reported to have been working towards this goal. > Yes, I'll send you my current patch for you to look at. One of the > engineers from Linaro is going to be pushing that patch set forward. > However, I don't know if it helps with this problem because I believe > that the suspend order is based on the implicit probe order of > devices, but my patch allows drivers to cause the probe order to get > rearranged at runtime. I don't believe there is a global list showing > the order that devices successfully got probed, but I may be wrong > here. Yes, I'm not convinced it'll change anything here. Though I guess it should be a simple matter of programming to move devices around the list depending on when they probe.