[PATCH v2] i2c: mxs: Let i2c-mxs be built for MX23

[PATCH v2] i2c: mxs: Let i2c-mxs be built for MX23

[Fabio Estevam]

MX23 and MX28 share the same I2C block, so let i2c-mxs be built for MX23 too.

Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
Changes since v1:
- Remove unneeded parenthesis

 drivers/i2c/busses/Kconfig |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 646068e..08748db 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -456,11 +456,11 @@ config I2C_MV64XXX
 	  will be called i2c-mv64xxx.
 
 config I2C_MXS
-	tristate "Freescale i.MX28 I2C interface"
-	depends on SOC_IMX28
+	tristate "Freescale i.MXS I2C interface"
+	depends on SOC_IMX28 || SOC_IMX23
 	help
 	  Say Y here if you want to use the I2C bus controller on
-	  the Freescale i.MX28 processors.
+	  the Freescale i.MXS processors.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-mxs.
-- 
1.7.1

Re: [PATCH v2] i2c: mxs: Let i2c-mxs be built for MX23

[Uwe Kleine-König]

On Fri, Oct 21, 2011 at 04:27:44PM -0200, Fabio Estevam wrote:
> MX23 and MX28 share the same I2C block, so let i2c-mxs be built for MX23 too.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
arch/arm/mach-mxs/devices/platform-mxs-i2c.c doesn't support i.MX23 yet,
but still I think the change is correct.

Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

> ---
> Changes since v1:
> - Remove unneeded parenthesis
> 
>  drivers/i2c/busses/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 646068e..08748db 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -456,11 +456,11 @@ config I2C_MV64XXX
>  	  will be called i2c-mv64xxx.
>  
>  config I2C_MXS
> -	tristate "Freescale i.MX28 I2C interface"
> -	depends on SOC_IMX28
> +	tristate "Freescale i.MXS I2C interface"
> +	depends on SOC_IMX28 || SOC_IMX23
>  	help
>  	  Say Y here if you want to use the I2C bus controller on
> -	  the Freescale i.MX28 processors.
> +	  the Freescale i.MXS processors.
>  
>  	  This driver can also be built as a module.  If so, the module
>  	  will be called i2c-mxs.
> -- 
> 1.7.1
> 
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH v2] i2c: mxs: Let i2c-mxs be built for MX23

[Fabio Estevam]

Hi Uwe,

On 10/21/2011 4:48 PM, Uwe Kleine-König wrote:
> On Fri, Oct 21, 2011 at 04:27:44PM -0200, Fabio Estevam wrote:
>> MX23 and MX28 share the same I2C block, so let i2c-mxs be built for MX23 too.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> arch/arm/mach-mxs/devices/platform-mxs-i2c.c doesn't support i.MX23 yet,
> but still I think the change is correct.

Yes, I know. I plan to submit the I2C arch/arm/mach-mxs related patches next week. 
 
> Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Thanks,

Fabio Estevam

Re: [PATCH v2] i2c: mxs: Let i2c-mxs be built for MX23

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]


> >> MX23 and MX28 share the same I2C block, so let i2c-mxs be built for MX23 too.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > arch/arm/mach-mxs/devices/platform-mxs-i2c.c doesn't support i.MX23 yet,
> > but still I think the change is correct.
> 
> Yes, I know. I plan to submit the I2C arch/arm/mach-mxs related patches next week. 
>  
> > Acked-by: Uwe Kleine-König <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Still NACK (unless somebody can explain to me how PIOQUEUE could work on MX23).

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]