From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] I2C: Make i2cdev_detach_adapter static Date: Fri, 18 Nov 2011 10:43:17 +0100 Message-ID: <20111118104317.7d150bab@endymion.delvare> References: <1321605731-3098-1-git-send-email-shubhrajyoti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1321605731-3098-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shubhrajyoti D Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, 18 Nov 2011 14:12:11 +0530, Shubhrajyoti D wrote: > The function i2cdev_detach_adapter is used only in i2c-dev file > making it static. This description doesn't match what the patch actually does. Please resubmit with proper subject and description. > Also removes the following sparse warning > > drivers/i2c/i2c-dev.c:582:5: warning: symbol 'i2cdev_notifier_call' > was not declared. Should it be static? > > Signed-off-by: Shubhrajyoti D > --- > drivers/i2c/i2c-dev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c > index c90ce50..57a45ce 100644 > --- a/drivers/i2c/i2c-dev.c > +++ b/drivers/i2c/i2c-dev.c > @@ -579,7 +579,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy) > return 0; > } > > -int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action, > +static int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action, > void *data) > { > struct device *dev = data; -- Jean Delvare