linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Guenter Roeck
	<guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>,
	Rodolfo Giometti <giometti-k2GhghHVRtY@public.gmane.org>,
	Michael Lawnick <ml.lawnick-Mmb7MZpHnFY@public.gmane.org>,
	Peter Korsgaard
	<peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c: reorganize muxes to a standard pattern
Date: Mon, 28 Nov 2011 09:22:27 +0100	[thread overview]
Message-ID: <20111128092227.3d5d6a25@endymion.delvare> (raw)
In-Reply-To: <87sjl9gtcv.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>

On Sun, 27 Nov 2011 22:15:12 +0100, Peter Korsgaard wrote:
> >>>>> "Jean" == Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> writes:
> 
> Hi,
> 
>  >> rename drivers/i2c/muxes/{gpio-i2cmux.c => i2c-mux-gpio.c} (100%)
>  >> rename drivers/i2c/muxes/{pca9541.c => i2c-mux-pca9541.c} (100%)
>  >> rename drivers/i2c/muxes/{pca954x.c => i2c-mux-pca954x.c} (100%)
> 
>  Jean> You forgot to rename Documentation/i2c/muxes/gpio-i2cmux.
> 
>  Jean> I thought the naming had been discussed before, but I can't find the
>  Jean> references, and to be honest the new names please me, so I have no
>  Jean> reason to decline your proposal. I would have appreciated an ack from
>  Jean> the driver authors (Cc'd) though. I'll apply your patch as soon as I
>  Jean> receive an updated version, unless I get an objection before then.
> 
> Are you referring to this?
> 
> http://thread.gmane.org/gmane.linux.drivers.i2c/7171/focus=7244

Ah, yes, that's the discussion I was looking for, thanks for digging it
out. My point wasn't totally wrong back then, but Wolfram's is simply
better, I admit.

> I originally called it i2c-gpiomux.c, and renamed it to gpio-i2cmux.c on
> request of you.
> 
> I don't mind the new name though, so:
> 
> Acked-by: Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>

Thanks,
-- 
Jean Delvare

  parent reply	other threads:[~2011-11-28  8:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 21:41 [PATCH] i2c: reorganize muxes to a standard pattern Wolfram Sang
     [not found] ` <1321220474-11378-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-21 12:52   ` Wolfram Sang
2011-11-27 20:48   ` Jean Delvare
     [not found]     ` <20111127214847.547542fb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-11-27 21:15       ` Peter Korsgaard
     [not found]         ` <87sjl9gtcv.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2011-11-28  8:22           ` Jean Delvare [this message]
     [not found]             ` <20111128092227.3d5d6a25-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-11-28  9:38               ` Wolfram Sang
     [not found]                 ` <20111128093835.GA4243-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-28  9:58                   ` Peter Korsgaard
     [not found]                     ` <874nxoh8l5.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2011-11-28 11:57                       ` Jean Delvare
     [not found]                         ` <20111128125751.3d6a3ca7-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-07 14:38                           ` Jean Delvare
     [not found]                             ` <20120107153820.45ed4b37-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-07 14:46                               ` Wolfram Sang
     [not found]                                 ` <20120107144559.GA2537-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-01-07 14:51                                   ` Jean Delvare
2012-03-31  6:21                                   ` Jean Delvare
     [not found]                                     ` <20120331082112.2fcc13c3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-03-31  6:56                                       ` Wolfram Sang
     [not found]                                         ` <20120331065641.GA9211-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-31  9:18                                           ` Peter Korsgaard
2011-11-27 22:04       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128092227.3d5d6a25@endymion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=giometti-k2GhghHVRtY@public.gmane.org \
    --cc=guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org \
    --cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ml.lawnick-Mmb7MZpHnFY@public.gmane.org \
    --cc=peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).