From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE Date: Wed, 28 Dec 2011 22:53:33 +0100 Message-ID: <20111228215333.GA13515@pengutronix.de> References: <1325076512.6997.1.camel@phoenix> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Return-path: Content-Disposition: inline In-Reply-To: <1325076512.6997.1.camel@phoenix> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Axel Lin Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rudolf Marek , "Jean Delvare (PC drivers, core)" , "Ben Dooks (embedded platforms)" , Olof Johansson , "Mark M. Hoffman" , Dirk Brandewie , Tomoya MORINAGA , Feng Tang , Sebastian Andrzej Siewior , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 28, 2011 at 08:48:32PM +0800, Axel Lin wrote: > Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE > tables. >=20 > Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const > and marked as __devinitconst. >=20 > This also fixes some warnings from checkpatch: > e.g. > WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id > #1096: FILE: i2c/busses/i2c-intel-mid.c:1096: > +static struct pci_device_id intel_mid_i2c_ids[] =3D { >=20 > Signed-off-by: Axel Lin Cool, thanks for the update! Acked-by: Wolfram Sang --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk77j90ACgkQD27XaX1/VRtAbQCdFBrZGeDihrgq7W1Ckl24Mw4U M6sAn3WRWfjPravbkxQtGSDGvlouDpXU =c5TY -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5--