From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: corentin.labbe-Um+J1D3rkBVWj0EZb7rXcA@public.gmane.org,
sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c-ali1535: enable SPARC support
Date: Thu, 5 Jan 2012 20:51:05 +0100 [thread overview]
Message-ID: <20120105205105.6a2d03b3@endymion.delvare> (raw)
In-Reply-To: <20111227.141759.1836372889946924661.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Hi David,
On Tue, 27 Dec 2011 14:17:59 -0500 (EST), David Miller wrote:
> From: "corentin.labbe" <corentin.labbe-Um+J1D3rkBVWj0EZb7rXcA@public.gmane.org>
> Date: Thu, 24 Nov 2011 12:01:36 +0100
>
> > The i2c-ali1535 driver don't work on SPARC, this is because it assumes that ioport address are 16bits wide (address stored with an unsigned short).
> > But on SPARC arch, ioports are mapped in memory and so are stored with an unsigned long.
> >
> > This patch corrects this by using pci_resource_start for getting IOMEM base address, then reading the SMBBA of the i2c busse and using together for I/O access.
> >
> > I like to thanks Jean DELVARE for reviewing of my patch.
> >
> > Thanks
> >
> > Signed-off-by: LABBE Corentin <corentin.labbe-Um+J1D3rkBVWj0EZb7rXcA@public.gmane.org>
>
> Jean has asked for some more changes, please follow his suggestions and
> resubmit, thanks.
Actually I ended up doing the changes myself, and the patch is queued
for 3.3 already:
http://khali.linux-fr.org/devel/linux-3/jdelvare-i2c/i2c-ali1535-enable-sparc-support.patch
Please let me know quickly if you see anything wrong there.
--
Jean Delvare
next prev parent reply other threads:[~2012-01-05 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 11:01 [PATCH] i2c-ali1535: enable SPARC support corentin.labbe
2011-11-24 18:50 ` Jean Delvare
[not found] ` <4ECE2410.7040608-Um+J1D3rkBVWj0EZb7rXcA@public.gmane.org>
2011-12-27 19:17 ` David Miller
[not found] ` <20111227.141759.1836372889946924661.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-01-05 19:51 ` Jean Delvare [this message]
[not found] ` <20120105205105.6a2d03b3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-05 19:55 ` David Miller
2012-01-05 20:06 ` Jean Delvare
2012-01-05 20:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105205105.6a2d03b3@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=corentin.labbe-Um+J1D3rkBVWj0EZb7rXcA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).