From: Jean Delvare <khali@linux-fr.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rudolf Marek <r.marek@assembler.cz>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Olof Johansson <olof@lixom.net>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Dirk Brandewie <dirk.brandewie@gmail.com>,
Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Feng Tang <feng.tang@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE
Date: Thu, 5 Jan 2012 21:25:53 +0100 [thread overview]
Message-ID: <20120105212553.02d69dda@endymion.delvare> (raw)
In-Reply-To: <1325076512.6997.1.camel@phoenix>
On Wed, 28 Dec 2011 20:48:32 +0800, Axel Lin wrote:
> Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE
> tables.
>
> Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const
> and marked as __devinitconst.
>
> This also fixes some warnings from checkpatch:
> e.g.
> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
> #1096: FILE: i2c/busses/i2c-intel-mid.c:1096:
> +static struct pci_device_id intel_mid_i2c_ids[] = {
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Rudolf Marek <r.marek@assembler.cz>
> Cc: Jean Delvare <khali@linux-fr.org>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Olof Johansson <olof@lixom.net>
> Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>
> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> Cc: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
> Cc: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Feng Tang <feng.tang@intel.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: linux-i2c@vger.kernel.org
> ---
> This resend updates the change log.
> This patch is against linux-next tree.
> Axel
>
> drivers/i2c/busses/i2c-ali1563.c | 2 +-
> drivers/i2c/busses/i2c-ali15x3.c | 2 +-
> drivers/i2c/busses/i2c-amd756.c | 2 +-
> drivers/i2c/busses/i2c-amd8111.c | 2 +-
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> drivers/i2c/busses/i2c-eg20t.c | 2 +-
> drivers/i2c/busses/i2c-hydra.c | 2 +-
> drivers/i2c/busses/i2c-i801.c | 2 +-
> drivers/i2c/busses/i2c-intel-mid.c | 2 +-
> drivers/i2c/busses/i2c-nforce2.c | 2 +-
> drivers/i2c/busses/i2c-pasemi.c | 2 +-
> drivers/i2c/busses/i2c-piix4.c | 2 +-
> drivers/i2c/busses/i2c-pxa-pci.c | 2 +-
> drivers/i2c/busses/i2c-sis5595.c | 2 +-
> drivers/i2c/busses/i2c-sis630.c | 2 +-
> drivers/i2c/busses/i2c-sis96x.c | 2 +-
> drivers/i2c/busses/i2c-via.c | 2 +-
> drivers/i2c/busses/i2c-viapro.c | 2 +-
> drivers/i2c/busses/scx200_acb.c | 2 +-
> 19 files changed, 19 insertions(+), 19 deletions(-)
> (...)
Applied, thanks!
--
Jean Delvare
prev parent reply other threads:[~2012-01-05 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 12:48 [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE Axel Lin
2011-12-28 21:06 ` Olof Johansson
2011-12-28 21:53 ` Wolfram Sang
2012-01-05 20:25 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105212553.02d69dda@endymion.delvare \
--to=khali@linux-fr.org \
--cc=axel.lin@gmail.com \
--cc=ben-linux@fluff.org \
--cc=bigeasy@linutronix.de \
--cc=dirk.brandewie@gmail.com \
--cc=feng.tang@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhoffman@lightlink.com \
--cc=olof@lixom.net \
--cc=r.marek@assembler.cz \
--cc=tomoya-linux@dsn.lapis-semi.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).