From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH RESEND] i2c: Convert to DEFINE_PCI_DEVICE_TABLE Date: Thu, 5 Jan 2012 21:25:53 +0100 Message-ID: <20120105212553.02d69dda@endymion.delvare> References: <1325076512.6997.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1325076512.6997.1.camel@phoenix> Sender: linux-kernel-owner@vger.kernel.org To: Axel Lin Cc: linux-kernel@vger.kernel.org, Rudolf Marek , "Ben Dooks (embedded platforms)" , Olof Johansson , "Mark M. Hoffman" , Dirk Brandewie , Tomoya MORINAGA , Wolfram Sang , Feng Tang , Sebastian Andrzej Siewior , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Wed, 28 Dec 2011 20:48:32 +0800, Axel Lin wrote: > Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE > tables. > > Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const > and marked as __devinitconst. > > This also fixes some warnings from checkpatch: > e.g. > WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id > #1096: FILE: i2c/busses/i2c-intel-mid.c:1096: > +static struct pci_device_id intel_mid_i2c_ids[] = { > > Signed-off-by: Axel Lin > Cc: Rudolf Marek > Cc: Jean Delvare > Cc: Ben Dooks > Cc: Olof Johansson > Cc: "Mark M. Hoffman" > Cc: Dirk Brandewie > Cc: Tomoya MORINAGA > Cc: Wolfram Sang > Cc: Feng Tang > Cc: Sebastian Andrzej Siewior > Cc: linux-i2c@vger.kernel.org > --- > This resend updates the change log. > This patch is against linux-next tree. > Axel > > drivers/i2c/busses/i2c-ali1563.c | 2 +- > drivers/i2c/busses/i2c-ali15x3.c | 2 +- > drivers/i2c/busses/i2c-amd756.c | 2 +- > drivers/i2c/busses/i2c-amd8111.c | 2 +- > drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +- > drivers/i2c/busses/i2c-eg20t.c | 2 +- > drivers/i2c/busses/i2c-hydra.c | 2 +- > drivers/i2c/busses/i2c-i801.c | 2 +- > drivers/i2c/busses/i2c-intel-mid.c | 2 +- > drivers/i2c/busses/i2c-nforce2.c | 2 +- > drivers/i2c/busses/i2c-pasemi.c | 2 +- > drivers/i2c/busses/i2c-piix4.c | 2 +- > drivers/i2c/busses/i2c-pxa-pci.c | 2 +- > drivers/i2c/busses/i2c-sis5595.c | 2 +- > drivers/i2c/busses/i2c-sis630.c | 2 +- > drivers/i2c/busses/i2c-sis96x.c | 2 +- > drivers/i2c/busses/i2c-via.c | 2 +- > drivers/i2c/busses/i2c-viapro.c | 2 +- > drivers/i2c/busses/scx200_acb.c | 2 +- > 19 files changed, 19 insertions(+), 19 deletions(-) > (...) Applied, thanks! -- Jean Delvare