linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
	Jochen Friedrich <jochen@scram.de>,
	Peter Korsgaard <jacmet@sunsite.dk>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Manuel Lauss <manuel.lauss@googlemail.com>,
	Barry Song <21cnbao@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Yong Zhang <yong.zhang0@gmail.com>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	Grant Likely <grant.likely@secretlab.ca>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: convert drivers/i2c/* to use module_platform_driver()
Date: Sat, 7 Jan 2012 16:00:18 +0100	[thread overview]
Message-ID: <20120107160018.43c9d7fe@endymion.delvare> (raw)
In-Reply-To: <20111127202212.44ebf4c4@endymion.delvare>

Axel,

On Sun, 27 Nov 2011 20:22:12 +0100, Jean Delvare wrote:
> On Sun, 27 Nov 2011 14:12:12 +0800, Axel Lin wrote:
> > diff --git a/drivers/i2c/muxes/gpio-i2cmux.c b/drivers/i2c/muxes/gpio-i2cmux.c
> > index 7b6ce62..e5fa695 100644
> > --- a/drivers/i2c/muxes/gpio-i2cmux.c
> > +++ b/drivers/i2c/muxes/gpio-i2cmux.c
> > @@ -165,18 +165,7 @@ static struct platform_driver gpiomux_driver = {
> >  	},
> >  };
> >  
> > -static int __init gpiomux_init(void)
> > -{
> > -	return platform_driver_register(&gpiomux_driver);
> > -}
> > -
> > -static void __exit gpiomux_exit(void)
> > -{
> > -	platform_driver_unregister(&gpiomux_driver);
> > -}
> > -
> > -module_init(gpiomux_init);
> > -module_exit(gpiomux_exit);
> > +module_platform_driver(gpiomux_driver);
> 
> This one would be better as a separate patch, as it touches a different
> subdirectory, which I am responsible for.

You resent a v2 of the patch without muxes/gpio-i2cmux.c, which is
good, but I never received the suggested separate patch for
muxes/gpio-i2cmux.c. Did I miss it somehow? Please send it quickly if
you want it to make it into kernel 3.3.

-- 
Jean Delvare

  parent reply	other threads:[~2012-01-07 15:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27  6:12 [PATCH] i2c: convert drivers/i2c/* to use module_platform_driver() Axel Lin
2011-11-27  8:47 ` Peter Korsgaard
2011-11-27  8:48 ` Wolfram Sang
2011-11-27 13:45 ` Jochen Friedrich
2011-11-27 19:22 ` Jean Delvare
2011-11-27 19:46   ` Wolfram Sang
     [not found]     ` <20111127194648.GA26533-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-11-27 19:50       ` Jean Delvare
2012-01-07 15:00   ` Jean Delvare [this message]
2011-11-28  0:56 ` Guan Xuetao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120107160018.43c9d7fe@endymion.delvare \
    --to=khali@linux-fr.org \
    --cc=21cnbao@gmail.com \
    --cc=axel.lin@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=jacmet@sunsite.dk \
    --cc=jochen@scram.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=manuel.lauss@googlemail.com \
    --cc=sameo@linux.intel.com \
    --cc=w.sang@pengutronix.de \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).