Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Sat, Jan 21, 2012 at 11:49:27PM +0100, Sylwester Nawrocki wrote:
> On 01/21/2012 10:57 PM, Mark Brown wrote:

> > It's just a Kconfig switch, the only issue is that users might not turn
> > it on and for platforms where there's not much driver support they're
> > more likely to not have done so.

> Yes, and some simple SoCs might probably never benefit from runtime PM due to
> their limited power modes. Hence enforcing RUNTIME_PM dependency on some 
> common drivers might not be sane. But it would be ideal not to work around
> things too much, and reimplement in drivers functionality that involves
> upper layers.

Yes, that's the thinking behind my approach of not touching existing
code - I don't feel too bad about making new stuff depend on new
features but for older stuff I'd rather leave it alone for now.  Once we
can manage to deliver the WFI states there would be a very useful win
there so there's going to be a benefit to users from turning it on.

> only.. I noticed recently that you did a nice work correcting broken s3c-fb 
> driver PM code. I've done similar corrections but the patches never left the 

Thanks.

> internal trees due to limited time for this. And there is also a DRM driver 
> for FIMD on Exynos now.

Yeah, I don't really have access to too much of the shiny new stuff
right now so I've not been able to take advantage of a lot of the stuff
you guys are doing.  My primary development platform is S3C6410 based at
the minute.