From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: core: comment says "transmitted" but means "received"
Date: Thu, 26 Jan 2012 09:02:43 +0100 [thread overview]
Message-ID: <20120126090243.2fe961cc@endymion.delvare> (raw)
In-Reply-To: <1327521565-14988-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wed, 25 Jan 2012 20:59:25 +0100, Wolfram Sang wrote:
> Fix that. Also convert this and the related comment to proper commenting
> style.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
> drivers/i2c/i2c-core.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 1e56061..e9c1893 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1386,8 +1386,10 @@ int i2c_master_send(const struct i2c_client *client, const char *buf, int count)
>
> ret = i2c_transfer(adap, &msg, 1);
>
> - /* If everything went ok (i.e. 1 msg transmitted), return #bytes
> - transmitted, else error code. */
> + /*
> + * If everything went ok (i.e. 1 msg transmitted), return #bytes
> + * transmitted, else error code.
> + */
> return (ret == 1) ? count : ret;
> }
> EXPORT_SYMBOL(i2c_master_send);
> @@ -1414,8 +1416,10 @@ int i2c_master_recv(const struct i2c_client *client, char *buf, int count)
>
> ret = i2c_transfer(adap, &msg, 1);
>
> - /* If everything went ok (i.e. 1 msg transmitted), return #bytes
> - transmitted, else error code. */
> + /*
> + * If everything went ok (i.e. 1 msg received), return #bytes received,
> + * else error code.
> + */
> return (ret == 1) ? count : ret;
> }
> EXPORT_SYMBOL(i2c_master_recv);
Applied, thanks.
--
Jean Delvare
prev parent reply other threads:[~2012-01-26 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 19:59 [PATCH] i2c: core: comment says "transmitted" but means "received" Wolfram Sang
[not found] ` <1327521565-14988-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-01-26 8:02 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126090243.2fe961cc@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).