[PATCH] (RESEND #2) i2c: prevent spurious interrupt

[PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Alan Cox]

From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Don't call i2c_enable on resume because it causes a spurious
interrupt.

Signed-off-by:  Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---

 drivers/i2c/busses/i2c-designware-pcidrv.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)


diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
index 37f4211..00e8f21 100644
--- a/drivers/i2c/busses/i2c-designware-pcidrv.c
+++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
@@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)
 	pci_restore_state(pdev);
 
 	i2c_dw_init(i2c);
-	i2c_dw_enable(i2c);
 	return 0;
 }
 

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Jean Delvare]

Hi Alan,

On Thu, 26 Jan 2012 16:13:34 +0000, Alan Cox wrote:
> From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> 
> Don't call i2c_enable on resume because it causes a spurious
> interrupt.
> 
> Signed-off-by:  Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> 
>  drivers/i2c/busses/i2c-designware-pcidrv.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Please come up with a decent subject line for this patch. Currently it
sounds very generic so Ben will never look at it, assuming I will take
care of it. But it is actually driver-specific, and that's a driver Ben
is responsible for, so I won't pick it.

> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 37f4211..00e8f21 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)
>  	pci_restore_state(pdev);
>  
>  	i2c_dw_init(i2c);
> -	i2c_dw_enable(i2c);
>  	return 0;
>  }
>  


-- 
Jean Delvare

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Ben Dooks]

On Fri, Jan 27, 2012 at 09:26:07AM +0100, Jean Delvare wrote:
> Hi Alan,
> 
> On Thu, 26 Jan 2012 16:13:34 +0000, Alan Cox wrote:
> > From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > 
> > Don't call i2c_enable on resume because it causes a spurious
> > interrupt.
> > 
> > Signed-off-by:  Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > ---
> > 
> >  drivers/i2c/busses/i2c-designware-pcidrv.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> Please come up with a decent subject line for this patch. Currently it
> sounds very generic so Ben will never look at it, assuming I will take
> care of it. But it is actually driver-specific, and that's a driver Ben

I agreee, the subject needs to be more specific to the driver it is
modifying. I would accept i2c-dw or i2c-designware as the start of
the subject.

Jean, thanks for clairfying ownership,

-- 
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Ben Dooks]

On Thu, Jan 26, 2012 at 04:13:34PM +0000, Alan Cox wrote:
> From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> 
> Don't call i2c_enable on resume because it causes a spurious
> interrupt.
> 
> Signed-off-by:  Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---

No-one seems to have decided to fix the title of this patch. If
there's nothing received before the end of the week then I will
decide to arbitrarily do something about it.

-- 
Ben

Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt

[Alan Cox]

On Mon, 13 Feb 2012 23:28:57 +0000
Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote:

> On Thu, Jan 26, 2012 at 04:13:34PM +0000, Alan Cox wrote:
> > From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > 
> > Don't call i2c_enable on resume because it causes a spurious
> > interrupt.
> > 
> > Signed-off-by:  Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > ---
> 
> No-one seems to have decided to fix the title of this patch.

What wants fixing ?