From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH] (RESEND #2) i2c: prevent spurious interrupt
Date: Sun, 29 Jan 2012 23:29:34 +0000 [thread overview]
Message-ID: <20120129232934.GD8441@trinity.fluff.org> (raw)
In-Reply-To: <20120127092607.09ed312a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Fri, Jan 27, 2012 at 09:26:07AM +0100, Jean Delvare wrote:
> Hi Alan,
>
> On Thu, 26 Jan 2012 16:13:34 +0000, Alan Cox wrote:
> > From: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> >
> > Don't call i2c_enable on resume because it causes a spurious
> > interrupt.
> >
> > Signed-off-by: Kristen Carlson Accardi <kristen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > ---
> >
> > drivers/i2c/busses/i2c-designware-pcidrv.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
>
> Please come up with a decent subject line for this patch. Currently it
> sounds very generic so Ben will never look at it, assuming I will take
> care of it. But it is actually driver-specific, and that's a driver Ben
I agreee, the subject needs to be more specific to the driver it is
modifying. I would accept i2c-dw or i2c-designware as the start of
the subject.
Jean, thanks for clairfying ownership,
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2012-01-29 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 16:13 [PATCH] (RESEND #2) i2c: prevent spurious interrupt Alan Cox
[not found] ` <20120126161319.22798.6071.stgit-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2012-01-27 8:26 ` Jean Delvare
[not found] ` <20120127092607.09ed312a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-01-29 23:29 ` Ben Dooks [this message]
2012-02-13 23:28 ` Ben Dooks
[not found] ` <20120213232857.GI2999-RazCHl0VsYgkUSuvROHNpA@public.gmane.org>
2012-02-13 23:45 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129232934.GD8441@trinity.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).